public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v8 02/23] pbs-api-types: add backing-device to DataStoreConfig
Date: Fri, 19 Apr 2024 17:55:45 +0200	[thread overview]
Message-ID: <20240419155606.112010-3-h.laimer@proxmox.com> (raw)
In-Reply-To: <20240419155606.112010-1-h.laimer@proxmox.com>

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 pbs-api-types/src/datastore.rs | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index 9fe45bc0..469b2ba4 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -160,6 +160,8 @@ pub const PRUNE_SCHEMA_KEEP_YEARLY: Schema =
         .minimum(1)
         .schema();
 
+pub const REMOVABLE_DATASTORE_MOUNT_DIR: &str = "/mnt/removable_datastore";
+
 #[api]
 #[derive(Debug, Default, Copy, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "lowercase")]
@@ -273,6 +275,12 @@ pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore
             format: &ApiStringFormat::PropertyString(&MaintenanceMode::API_SCHEMA),
             type: String,
         },
+        "backing-device": {
+            description: "The UUID of the filesystem partition for removable datastores.",
+            optional: true,
+            format: &proxmox_schema::api_types::UUID_FORMAT,
+            type: String,
+        }
     }
 )]
 #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)]
@@ -316,6 +324,11 @@ pub struct DataStoreConfig {
     /// Maintenance mode, type is either 'offline' or 'read-only', message should be enclosed in "
     #[serde(skip_serializing_if = "Option::is_none")]
     pub maintenance_mode: Option<String>,
+
+    /// The UUID of the device(for removable datastores)
+    #[updater(skip)]
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub backing_device: Option<String>,
 }
 
 impl DataStoreConfig {
@@ -332,9 +345,16 @@ impl DataStoreConfig {
             notify: None,
             tuning: None,
             maintenance_mode: None,
+            backing_device: None,
         }
     }
 
+    pub fn get_mount_point(&self) -> Option<String> {
+        self.backing_device
+            .as_ref()
+            .map(|uuid| format!("{REMOVABLE_DATASTORE_MOUNT_DIR}/{uuid}"))
+    }
+
     pub fn get_maintenance_mode(&self) -> Option<MaintenanceMode> {
         self.maintenance_mode.as_ref().and_then(|str| {
             MaintenanceMode::deserialize(proxmox_schema::de::SchemaDeserializer::new(
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2024-04-19 15:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 15:55 [pbs-devel] [PATCH proxmox-backup v8 00/23] add removable datastores Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 01/23] tools: add disks utility functions Hannes Laimer
2024-04-19 15:55 ` Hannes Laimer [this message]
2024-04-22  7:12   ` [pbs-devel] [PATCH proxmox-backup v8 02/23] pbs-api-types: add backing-device to DataStoreConfig Thomas Lamprecht
2024-04-22  9:29     ` Dietmar Maurer
2024-04-22  9:48       ` Dietmar Maurer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 03/23] disks: add UUID to partition info Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 04/23] datastore: add helper for checking if a removable datastore is available Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 05/23] api: admin: add (un)mount endpoint for removable datastores Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 06/23] api: removable datastore creation Hannes Laimer
2024-04-22  7:28   ` Dietmar Maurer
2024-04-22  7:37     ` Hannes Laimer
2024-04-22  9:05   ` Christian Ebner
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 07/23] api: disks list: add exclude-used flag Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 08/23] pbs-api-types: add removable/is-available flag to DataStoreListItem Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 09/23] bin: manager: add (un)mount command Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 10/23] add auto-mounting for removable datastores Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 11/23] datastore: handle deletion of removable datastore properly Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 12/23] docs: add removable datastores section Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 13/23] ui: add partition selector form Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 14/23] ui: add removable datastore creation support Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 15/23] ui: add (un)mount button to summary Hannes Laimer
2024-04-19 15:55 ` [pbs-devel] [PATCH proxmox-backup v8 16/23] ui: tree: render unmounted datastores correctly Hannes Laimer
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 17/23] ui: utils: make parseMaintenanceMode more robust Hannes Laimer
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 18/23] ui: add datastore status mask for unmounted removable datastores Hannes Laimer
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 19/23] ui: maintenance: fix disable msg field if no type is selected Hannes Laimer
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 20/23] ui: render 'unmount' maintenance mode correctly Hannes Laimer
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 21/23] api: node: allow creation of removable datastore through directory endpoint Hannes Laimer
2024-04-22  9:27   ` Christian Ebner
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 22/23] api: node: include removable datastores in directory list Hannes Laimer
2024-04-19 15:56 ` [pbs-devel] [PATCH proxmox-backup v8 23/23] ui: support create removable datastore through directory creation Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240419155606.112010-3-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal