From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v7 18/20] ui: add datastore status mask for unmounted removable datastores
Date: Fri, 19 Apr 2024 10:58:32 +0200 [thread overview]
Message-ID: <20240419085834.32850-19-h.laimer@proxmox.com> (raw)
In-Reply-To: <20240419085834.32850-1-h.laimer@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
www/css/ext6-pbs.css | 12 ++++++++++++
www/datastore/Summary.js | 21 +++++++++++++--------
2 files changed, 25 insertions(+), 8 deletions(-)
diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 706e681e..891189ae 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -261,6 +261,18 @@ span.snapshot-comment-column {
content: "\f0ad";
}
+.pbs-unplugged-mask div.x-mask-msg-text {
+ background: None;
+ padding: 12px 0 0;
+}
+
+.pbs-unplugged-mask:before {
+ font-size: 3em;
+ display: flex;
+ justify-content: center;
+ content: "\f1e6";
+}
+
/* the small icons TODO move to proxmox-widget-toolkit */
.pmx-tree-icon-custom:after {
position: relative;
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 49aa3b3c..33b4e18a 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -61,16 +61,21 @@ Ext.define('PBS.DataStoreInfo', {
Proxmox.Utils.API2Request({
url: `/config/datastore/${me.view.datastore}`,
success: function(response) {
- const config = response.result.data;
- if (config['maintenance-mode']) {
- const [_type, msg] = PBS.Utils.parseMaintenanceMode(config['maintenance-mode']);
- me.view.el.mask(
- `${gettext('Datastore is in maintenance mode')}${msg ? ': ' + msg : ''}`,
- 'fa pbs-maintenance-mask',
- );
- } else {
+ let maintenanceString = response.result.data['maintenance-mode'];
+ let removable = !!response.result.data['backing-device'];
+ if (!maintenanceString && !removable) {
me.view.el.mask(gettext('Datastore is not available'));
+ return;
}
+
+ let [_type, msg] = PBS.Utils.parseMaintenanceMode(maintenanceString);
+ let isUnplugged = !maintenanceString && removable;
+ let maskMessage = isUnplugged
+ ? gettext('Datastore is not mounted')
+ : `${gettext('Datastore is in maintenance mode')}${msg ? ': ' + msg : ''}`;
+
+ let maskIcon = isUnplugged ? 'fa pbs-unplugged-mask' : 'fa pbs-maintenance-mask';
+ me.view.el.mask(maskMessage, maskIcon);
},
});
return;
--
2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-19 8:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 8:58 [pbs-devel] [PATCH proxmox-backup v7 00/20] add " Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 01/20] tools: add disks utility functions Hannes Laimer
2024-04-19 9:54 ` Christian Ebner
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 02/20] pbs-api-types: add backing-device to DataStoreConfig Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 03/20] disks: add UUID to partition info Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 04/20] datastore: add helper for checking if a removable datastore is available Hannes Laimer
2024-04-19 9:14 ` Christian Ebner
2024-04-19 15:35 ` Hannes Laimer
2024-04-22 8:23 ` Christian Ebner
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 05/20] api: admin: add (un)mount endpoint for removable datastores Hannes Laimer
2024-04-19 10:21 ` Christian Ebner
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 06/20] api: removable datastore creation Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 07/20] api: disks list: add exclude-used flag Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 08/20] pbs-api-types: add removable/is-available flag to DataStoreListItem Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 09/20] bin: manager: add (un)mount command Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 10/20] add auto-mounting for removable datastores Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 11/20] datastore: handle deletion of removable datastore properly Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 12/20] docs: add removable datastores section Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 13/20] ui: add partition selector form Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 14/20] ui: add removable datastore creation support Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 15/20] ui: add (un)mount button to summary Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 16/20] ui: tree: render unmounted datastores correctly Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 17/20] ui: utils: make parseMaintenanceMode more robust Hannes Laimer
2024-04-19 8:58 ` Hannes Laimer [this message]
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 19/20] ui: maintenance: fix disable msg field if no type is selected Hannes Laimer
2024-04-19 8:58 ` [pbs-devel] [PATCH proxmox-backup v7 20/20] ui: render 'unmount' maintenance mode correctly Hannes Laimer
2024-04-19 10:10 ` [pbs-devel] [PATCH proxmox-backup v7 00/20] add removable datastores Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419085834.32850-19-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox