From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v5 00/10] Add GC job status to datastore and global prune job view.
Date: Thu, 18 Apr 2024 12:16:56 +0200 [thread overview]
Message-ID: <20240418101706.237597-1-l.wagner@proxmox.com> (raw)
Adopted this patch series since Stefan Lendl left the company. Tested
v4 and did some minor touchups (see changelog).
Original coverletter:
Fix #3217: Addition of a new tab "Prune & GC" in "Datastore" and not in each Datastore created
Fix #4723: add last, next run, status, duration to gc
Extends the garbage collection view to display in addition to the schedule:
* State (of last run)
* Duration (of last run)
* Last Run Date
* Next Run Date (if scheduled)
* Removed Bytes (in last run)
* Pending Bytes (as of last run)
Additionally the api returns the following which is also displayed via CLI:
* Removed Chunks (in last run)
* Pending Chunks (as of last run)
In the Datastore global overview, the prune view is extended to show the same
details for all availible datastores also the ones without a gc-schedule.
Allows editing the schedule, showing the log of the last run and manually
running the gc job. In the global view, by selecting the row of the datastore.
Adds a proxmox-backup-manager cli command to list all gc jobs
`proxmox-backup-manager garbage-collection list`
Changes v4 -> v5:
* Fix eslint warnings
* Pretty print durations/timestamps/bytes in CLI output
* Include refs to bugzilla in 2 commit messages
Changes v3 -> v4:
* Show removed and pending data in bytes instead of number of chunks
Changes v2 -> v3:
* Fixed indentation
* Added git trailers
Changes v1 -> v2:
* Sort imports
* Fix eslint warnings
* Update columns in GC Job view to fill the entire width
* Not include path PruneJobEdit (sent separatly)
This is based on a series from g.goller
Changes to g.goller's series:
* Rename endpoint from gc-info to gc-job-status
* Add list-all-gc-jobs endpoint
* UI uses Grid (table) view instead of model grid
* Implement GC job view in global view
proxmox-backup:
Lukas Wagner (2):
ui: gcview: fix eslint warnings
proxmox-backup-mgr: gc jobs: pretty-print bytes/duration/timestamps
Stefan Lendl (8):
api: garbage collect job status
fix #3217: ui: global prune and gc job view
ui: move prune and gc widget to config
ui: hide datastore column in local gc view
ui: order Prune & GC before Sync Jobs
fix #4723: cli: list gc jobs with proxmox-backup-manager
ui: show removed and pending data of last run in bytes
ui: configure width and flex on GC Jobs columns
pbs-api-types/src/datastore.rs | 46 ++++++
pbs-tools/src/format.rs | 14 +-
src/api2/admin/datastore.rs | 131 +++++++++++++++-
src/api2/admin/gc.rs | 57 +++++++
src/api2/admin/mod.rs | 2 +
src/bin/proxmox-backup-manager.rs | 62 ++++++++
www/Makefile | 4 +-
www/Utils.js | 6 +-
www/config/GCView.js | 245 ++++++++++++++++++++++++++++++
www/config/PruneAndGC.js | 52 +++++++
www/datastore/DataStoreList.js | 11 +-
www/datastore/Panel.js | 3 +-
www/datastore/PruneAndGC.js | 133 ----------------
www/window/GCJobEdit.js | 28 ++++
14 files changed, 645 insertions(+), 149 deletions(-)
create mode 100644 src/api2/admin/gc.rs
create mode 100644 www/config/GCView.js
create mode 100644 www/config/PruneAndGC.js
delete mode 100644 www/datastore/PruneAndGC.js
create mode 100644 www/window/GCJobEdit.js
Summary over all repositories:
14 files changed, 645 insertions(+), 149 deletions(-)
--
Generated by git-murpp 0.7.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2024-04-18 10:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 10:16 Lukas Wagner [this message]
2024-04-18 10:16 ` [pbs-devel] [PATCH proxmox-backup v5 01/10] api: garbage collect job status Lukas Wagner
2024-04-18 10:16 ` [pbs-devel] [PATCH proxmox-backup v5 02/10] fix #3217: ui: global prune and gc job view Lukas Wagner
2024-04-18 10:16 ` [pbs-devel] [PATCH proxmox-backup v5 03/10] ui: move prune and gc widget to config Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 04/10] ui: hide datastore column in local gc view Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 05/10] ui: order Prune & GC before Sync Jobs Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 06/10] fix #4723: cli: list gc jobs with proxmox-backup-manager Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 07/10] ui: show removed and pending data of last run in bytes Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 08/10] ui: configure width and flex on GC Jobs columns Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 09/10] ui: gcview: fix eslint warnings Lukas Wagner
2024-04-18 10:17 ` [pbs-devel] [PATCH proxmox-backup v5 10/10] proxmox-backup-mgr: gc jobs: pretty-print bytes/duration/timestamps Lukas Wagner
2024-04-18 12:11 ` [pbs-devel] [PATCH proxmox-backup v5 00/10] Add GC job status to datastore and global prune job view Gabriel Goller
2024-04-23 12:37 ` [pbs-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418101706.237597-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox