From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v4 00/22] add removable datastores
Date: Tue, 16 Apr 2024 17:23:54 +0200 [thread overview]
Message-ID: <20240416152416.96561-1-h.laimer@proxmox.com> (raw)
These patches add support for removable datastores. All removable
datastores have a backing-device(a UUID) associated with them. Removable
datastores work like normal ones, just that they can be unplugged. It is
possible to create a removable datastore, sync backups onto it, unplug
it and use it on a different PBS.
The datastore path is also the mountpoint for the removable datastore.
By default when creating one through the web UI it will be
`/mnt/removable-datastores/<UUID>`, using the CLI it is possible to
specify something else. Since a removable datastore is associated with
the UUID of a partition, it is technically possible to have two
removable datastores on the same device, but I don't think there is a
use-case that couldn't also be done using namespaces.
When a removable datastore is deleted and 'destroy-data' is set, the
device has to be plugged in. If 'destroy-data' is not set the datastore
can be deleted even if the device is not present. Removable datastores
are automatically mounted when plugged in. At the API service start all
Patche 20/22 is not strictly needed, but they made sense in
this context, so I kept them in this series.
v4: thanks a lot @Dietmar and @Christian
* make check if mounted wayyy faster, checking takes ~0.1ms, only
happens once per operation and only on removable datastores so that
seems fast enough to just do it instead of keeping track of the state
* don't keep track of mounting state
* drop Unplugged maintenance mode
* use UUID_FORMAT for uuid field
* a lot of small things, like use of bail!, inline format!, ...
* include improvement to cache handling
v3:
* remove lazy unmounting (since 9cba51ac782d04085c0af55128f32178e5132358 is applied)
* fix CLI (un)mount command, thanks @Gabriel
* add removable datastore CLI autocomplete helper
* rebase onto master
* move ui patches to the end
thanks @Lukas and @Thomas for the feedback
v2:
* fix datastore 'add' button in the UI
* some format!("{}", a) -> format!("{a}")
* replace `const` with `let` in js code
* change icon `fa-usb` -> `fa-plug`
* add some docs
* add JDoc for parseMaintenanceMode
* proxmox-schema dep bump
Hannes Laimer (22):
tools: add disks utility functions
datastore: make dropping from cache more efficient
pbs-api-types: add backing-device to DataStoreConfig
disks: add UUID to partition info
add helper for checking if a removable datastore is available
api2: admin: add (un)mount endpoint for removable datastores
api2: removable datastore creation
api2: disks list: add only-unused flag
pbs-api-types: datastore: use new proxmox_schema::de for
deserialization
pbs-api-types: add removable/is-available flag to DataStoreListItem
pb-manager: add (un)mount command
add auto-mounting for removable datastores
datastore: handle deletion of removable datastore properly
docs: mention maintenance mode reset when removable datastore is
unplugged
ui: add partition selector form
ui: add removable datastore creation support
ui: add (un)mount button to summary
ui: display removable datastores in list
ui: utils: render unplugged datastores correctly
ui: utils: make parseMaintenanceMode more robust
ui: add datastore status mask for unplugged removable datastores
ui: maintenance: fix disable msg field if no type is selected
debian/proxmox-backup-server.install | 1 +
debian/proxmox-backup-server.udev | 3 +
docs/maintenance.rst | 2 +
etc/Makefile | 3 +-
etc/removable-device-attach@.service.in | 8 +
pbs-api-types/src/datastore.rs | 32 +++-
pbs-api-types/src/maintenance.rs | 4 +
pbs-config/src/datastore.rs | 14 ++
pbs-datastore/src/datastore.rs | 119 ++++++++----
pbs-datastore/src/lib.rs | 2 +-
src/api2/admin/datastore.rs | 192 ++++++++++++++++++--
src/api2/config/datastore.rs | 75 +++++++-
src/api2/node/disks/mod.rs | 8 +
src/api2/status.rs | 18 +-
src/bin/proxmox_backup_manager/datastore.rs | 130 ++++++++++++-
src/tools/disks/mod.rs | 90 ++++++++-
www/Makefile | 1 +
www/NavigationTree.js | 15 +-
www/Utils.js | 31 +++-
www/css/ext6-pbs.css | 20 ++
www/datastore/DataStoreListSummary.js | 1 +
www/datastore/Summary.js | 103 ++++++++++-
www/form/PartitionSelector.js | 74 ++++++++
www/window/DataStoreEdit.js | 51 ++++++
www/window/MaintenanceOptions.js | 7 +-
25 files changed, 903 insertions(+), 101 deletions(-)
create mode 100644 etc/removable-device-attach@.service.in
create mode 100644 www/form/PartitionSelector.js
--
2.39.2
next reply other threads:[~2024-04-16 15:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 15:23 Hannes Laimer [this message]
2024-04-16 15:23 ` [pbs-devel] [PATCH proxmox-backup v4 01/22] tools: add disks utility functions Hannes Laimer
2024-04-16 15:23 ` [pbs-devel] [PATCH proxmox-backup v4 02/22] datastore: make dropping from cache more efficient Hannes Laimer
2024-04-17 7:48 ` Christian Ebner
2024-04-17 9:37 ` Dietmar Maurer
2024-04-16 15:23 ` [pbs-devel] [PATCH proxmox-backup v4 03/22] pbs-api-types: add backing-device to DataStoreConfig Hannes Laimer
2024-04-16 15:23 ` [pbs-devel] [PATCH proxmox-backup v4 04/22] disks: add UUID to partition info Hannes Laimer
2024-04-16 15:23 ` [pbs-devel] [PATCH proxmox-backup v4 05/22] add helper for checking if a removable datastore is available Hannes Laimer
2024-04-17 7:56 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 06/22] api2: admin: add (un)mount endpoint for removable datastores Hannes Laimer
2024-04-17 8:08 ` Christian Ebner
2024-04-17 9:19 ` Hannes Laimer
2024-04-17 9:26 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 07/22] api2: removable datastore creation Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 08/22] api2: disks list: add exclude-used flag Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 09/22] pbs-api-types: datastore: use new proxmox_schema::de for deserialization Hannes Laimer
2024-04-17 8:13 ` Christian Ebner
2024-04-17 9:08 ` Hannes Laimer
2024-04-17 9:38 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 10/22] pbs-api-types: add removable/is-available flag to DataStoreListItem Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 11/22] pb-manager: add (un)mount command Hannes Laimer
2024-04-17 8:21 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 12/22] add auto-mounting for removable datastores Hannes Laimer
2024-04-17 8:29 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 13/22] datastore: handle deletion of removable datastore properly Hannes Laimer
2024-04-17 8:34 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 14/22] docs: mention maintenance mode reset when removable datastore is unplugged Hannes Laimer
2024-04-17 8:46 ` Hannes Laimer
2024-04-17 8:52 ` Christian Ebner
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 15/22] ui: add partition selector form Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 16/22] ui: add removable datastore creation support Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 17/22] ui: add (un)mount button to summary Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 18/22] ui: display removable datastores in list Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 19/22] ui: utils: render unplugged datastores correctly Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 20/22] ui: utils: make parseMaintenanceMode more robust Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 21/22] ui: add datastore status mask for unplugged removable datastores Hannes Laimer
2024-04-16 15:24 ` [pbs-devel] [PATCH proxmox-backup v4 22/22] ui: maintenance: fix disable msg field if no type is selected Hannes Laimer
2024-04-17 9:16 ` [pbs-devel] [PATCH proxmox-backup v4 00/22] add removable datastores Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416152416.96561-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox