public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Lendl <s.lendl@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v4 proxmox-backup 0/8] Add GC job status to datastore and global prune job view.
Date: Thu,  4 Apr 2024 15:50:21 +0200	[thread overview]
Message-ID: <20240404135028.373407-2-s.lendl@proxmox.com> (raw)

Fix #3217: Addition of a new tab "Prune & GC" in "Datastore" and not in each Datastore created
Fix #4723: add last, next run, status, duration to gc

Extends the garbage collection view to display in addition to the schedule:
* State (of last run)
* Duration (of last run)
* Last Run Date
* Next Run Date (if scheduled)
* Removed Bytes (in last run)
* Pending Bytes (as of last run)

Additionally the api returns the following which is also displayed via CLI:
* Removed Chunks (in last run)
* Pending Chunks (as of last run)

In the Datastore global overview, the prune view is extended to show the same
details for all availible datastores also the ones without a gc-schedule.

Allows editing the schedule, showing the log of the last run and manually
running the gc job. In the global view, by selecting the row of the datastore.

Adds a proxmox-backup-manager cli command to list all gc jobs
`proxmox-backup-manager garbage-collection list`

Changes v3 -> v4:
* Show removed and pending data in bytes instead of number of chunks

Changes v2 -> v3:
* Fixed indentation
* Added git trailers

Changes v1 -> v2:
* Sort imports
* Fix eslint warnings
* Update columns in GC Job view to fill the entire width
* Not include path PruneJobEdit (sent separatly)

This is based on a series from g.goller
Changes to g.goller's series:
* Rename endpoint from gc-info to gc-job-status
* Add list-all-gc-jobs endpoint
* UI uses Grid (table) view instead of model grid
* Implement GC job view in global view


Stefan Lendl (8):
  api: garbage collect job status
  ui: global prune and gc job view
  ui: move prune and gc widget to config
  ui: hide datastore column in local gc view
  ui: order Prune & GC before Sync Jobs
  cli: list gc jobs with proxmox-backup-manager
  ui: show removed and pending data of last run in bytes
  ui: configure width and flex on GC Jobs columns

 pbs-api-types/src/datastore.rs    |  46 ++++++
 src/api2/admin/datastore.rs       | 131 +++++++++++++++-
 src/api2/admin/gc.rs              |  57 +++++++
 src/api2/admin/mod.rs             |   2 +
 src/bin/proxmox-backup-manager.rs |  33 ++++
 www/Makefile                      |   4 +-
 www/Utils.js                      |   6 +-
 www/config/GCView.js              | 245 ++++++++++++++++++++++++++++++
 www/config/PruneAndGC.js          |  52 +++++++
 www/datastore/DataStoreList.js    |  11 +-
 www/datastore/Panel.js            |   3 +-
 www/datastore/PruneAndGC.js       | 133 ----------------
 www/window/GCJobEdit.js           |  28 ++++
 13 files changed, 603 insertions(+), 148 deletions(-)
 create mode 100644 src/api2/admin/gc.rs
 create mode 100644 www/config/GCView.js
 create mode 100644 www/config/PruneAndGC.js
 delete mode 100644 www/datastore/PruneAndGC.js
 create mode 100644 www/window/GCJobEdit.js

-- 
2.44.0





             reply	other threads:[~2024-04-04 13:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 13:50 Stefan Lendl [this message]
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 2/8] ui: global prune and gc job view Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 3/8] ui: move prune and gc widget to config Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 4/8] ui: hide datastore column in local gc view Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 5/8] ui: order Prune & GC before Sync Jobs Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 6/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 7/8] ui: show removed and pending data of last run in bytes Stefan Lendl
2024-04-04 13:50 ` [pbs-devel] [PATCH v4 proxmox-backup 8/8] ui: configure width and flex on GC Jobs columns Stefan Lendl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240404135028.373407-2-s.lendl@proxmox.com \
    --to=s.lendl@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal