[pbs-devel] [PATCH proxmox-backup 1/3] docs: lto barcod generator: disable add button when fields are not valid

[pbs-devel] [PATCH proxmox-backup 1/3] docs: lto barcod generator: disable add button when fields are not valid

[Dominik Csapak]

otherwise we end up with entries in the list that won't be
displayed/printed anyway.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 docs/lto-barcode/label-setup.js | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/docs/lto-barcode/label-setup.js b/docs/lto-barcode/label-setup.js
index e65cc7a4..b42a3080 100644
--- a/docs/lto-barcode/label-setup.js
+++ b/docs/lto-barcode/label-setup.js
@@ -46,6 +46,23 @@ Ext.define('LabelSetupPanel', {
 	    let params = view.getValues();
 	    list.getStore().add(params);
 	},
+
+	validitychange: function() {
+	    let me = this;
+	    let isValid = true;
+	    me.getView().query('field').forEach((field) => {
+		if (!field.isValid()) {
+		    isValid = false;
+		}
+	    });
+	    me.lookup('addButton').setDisabled(!isValid);
+	},
+
+	control: {
+	    'field': {
+		validitychange: 'validitychange',
+	    },
+	},
     },
 
     items: [
@@ -93,6 +110,7 @@ Ext.define('LabelSetupPanel', {
 		{
 		    xtype: 'button',
 		    text: 'Add',
+		    reference: 'addButton',
 		    handler: 'onAdd',
 		},
 	    ],
-- 
2.39.2

[pbs-devel] [PATCH proxmox-backup 2/3] docs: lto barcode generator: add lto-9 type

[Dominik Csapak]

and make it the new default

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 docs/lto-barcode/label-setup.js | 2 +-
 docs/lto-barcode/tape-type.js   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/lto-barcode/label-setup.js b/docs/lto-barcode/label-setup.js
index b42a3080..c7362aad 100644
--- a/docs/lto-barcode/label-setup.js
+++ b/docs/lto-barcode/label-setup.js
@@ -84,7 +84,7 @@ Ext.define('LabelSetupPanel', {
 		    xtype: 'ltoTapeType',
 		    name: 'tape_type',
 		    fieldLabel: 'Type',
-		    value: 'L8',
+		    value: 'L9',
 		},
 		{
 		    xtype: 'ltoLabelStyle',
diff --git a/docs/lto-barcode/tape-type.js b/docs/lto-barcode/tape-type.js
index 33ec0152..7edb59ea 100644
--- a/docs/lto-barcode/tape-type.js
+++ b/docs/lto-barcode/tape-type.js
@@ -11,6 +11,7 @@ Ext.define('LtoTapeType', {
     store: {
 	field: ['value', 'text'],
 	data: [
+	    { value: 'L9', text: "LTO-9" },
 	    { value: 'L8', text: "LTO-8" },
 	    { value: 'L7', text: "LTO-7" },
 	    { value: 'L6', text: "LTO-6" },
-- 
2.39.2

[pbs-devel] [PATCH proxmox-backup 3/3] docs: lto barcode generator: add worm tape types

[Dominik Csapak]

see
https://www.ibm.com/docs/en/ts4500-tape-library?topic=media-lto-bar-code-labels

for a reference of the codes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively we could add a 'WORM' checkbox, but then we'd have to
modify the value before adding it to the list.

 docs/lto-barcode/tape-type.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/docs/lto-barcode/tape-type.js b/docs/lto-barcode/tape-type.js
index 7edb59ea..e487f47b 100644
--- a/docs/lto-barcode/tape-type.js
+++ b/docs/lto-barcode/tape-type.js
@@ -12,12 +12,19 @@ Ext.define('LtoTapeType', {
 	field: ['value', 'text'],
 	data: [
 	    { value: 'L9', text: "LTO-9" },
+	    { value: 'LZ', text: "LTO-9 (WORM)" },
 	    { value: 'L8', text: "LTO-8" },
+	    { value: 'LY', text: "LTO-8 (WORM)" },
 	    { value: 'L7', text: "LTO-7" },
+	    { value: 'LX', text: "LTO-7 (WORM)" },
 	    { value: 'L6', text: "LTO-6" },
+	    { value: 'LW', text: "LTO-6 (WORM)" },
 	    { value: 'L5', text: "LTO-5" },
+	    { value: 'LV', text: "LTO-5 (WORM)" },
 	    { value: 'L4', text: "LTO-4" },
+	    { value: 'LU', text: "LTO-4 (WORM)" },
 	    { value: 'L3', text: "LTO-3" },
+	    { value: 'LT', text: "LTO-3 (WORM)" },
 	    { value: 'CU', text: "Cleaning Unit" },
 	],
     },
-- 
2.39.2

Re: [pbs-devel] [PATCH proxmox-backup 1/3] docs: lto barcod generator: disable add button when fields are not valid

[Dominik Csapak]

argh, sorry for the typo in the commit subject
i'll fix it for a v2, but if someone could fix it up when applying
i'd appreciate it ;)

[pbs-devel] applied: [PATCH proxmox-backup 1/3] docs: lto barcod generator: disable add button when fields are not valid

[Dietmar Maurer]

applied serie