From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive
Date: Wed, 6 Mar 2024 15:34:10 +0100 [thread overview]
Message-ID: <20240306143422.114335-1-g.goller@proxmox.com> (raw)
To better debug the creation of the pxar archive, we encode the
creation_params (the parameters passed to the cli) inside the pxar
archive. Like this we just need to locate the `.pxar_creation_params`
file in the archive and we can check which arguments have been used.
To realize this, we unify all the parameters of the `create_backup`
function so that we don't need an additional struct (which in turn
introduces additional maintenance efforts).
An example `.pxar_creation_params` file would look like this:
{
"backupspec": [
"test.pxar:linux"
],
"chunk-size": 4096,
"exclude": [
"MAINTAINERS"
],
"skip-e2big-xattr": true
}
Some background:
The original idea came from Dietmar and while it is surely useful, I
don't really like my implementation (most likely this is a skill-issue
from my side). So suggestions/critique of any kind is welcome!
proxmox-backup:
Gabriel Goller (3):
pxar: factor out encode_file
client: unify parameters and write to file
pxar: added creation parameters
pbs-client/src/pxar/create.rs | 23 ++++++-
pbs-client/src/pxar_backup_stream.rs | 5 +-
proxmox-backup-client/src/main.rs | 29 +++++---
.../src/proxmox_restore_daemon/api.rs | 2 +-
pxar-bin/Cargo.toml | 1 +
pxar-bin/src/main.rs | 67 ++++++++++++-------
tests/catar.rs | 1 +
7 files changed, 89 insertions(+), 39 deletions(-)
Summary over all repositories:
7 files changed, 89 insertions(+), 39 deletions(-)
--
Generated by git-murpp 0.5.0
next reply other threads:[~2024-03-06 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:34 Gabriel Goller [this message]
2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 1/3] pxar: factor out encode_file Gabriel Goller
2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 2/3] client: unify parameters and write to file Gabriel Goller
2024-03-06 14:34 ` [pbs-devel] [PATCH proxmox-backup 3/3] pxar: added creation parameters Gabriel Goller
2024-03-06 15:13 ` [pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive Christian Ebner
2024-03-07 9:22 ` Gabriel Goller
2024-03-07 9:50 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306143422.114335-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox