public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job
Date: Wed,  6 Mar 2024 15:11:50 +0100	[thread overview]
Message-ID: <20240306141153.419283-1-c.ebner@proxmox.com> (raw)

Adds a global summary of the transferred chunk size and count, as well
as the average transfer rate of a sync job to it's task log.

Patch 1/3 introduces a PullStats object, used to return the relevant
data from each pull related method call.

Patch 2/3 adds the summary log line to the tasklog.

Patch 3/3 finally adapts the current log output to use the
functionality of `HumanByte` to produce consistent output.

Tested by creating a local sync job and syncing a datastore, checking
the output in the tasklog.
Chunk counts where compared to `find .chunks -type f -print | wc -l`.

Bugtracker link:
https://bugzilla.proxmox.com/show_bug.cgi?id=5285

Christian Ebner (3):
  server: sync: return `PullStats` for pull related methods
  fix #5285: api: sync: add job summary to task log
  server: sync: use HumanByte for task log output

 src/api2/pull.rs   |  12 ++++-
 src/server/pull.rs | 130 ++++++++++++++++++++++++++++++---------------
 2 files changed, 99 insertions(+), 43 deletions(-)

-- 
2.39.2





             reply	other threads:[~2024-03-06 14:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 14:11 Christian Ebner [this message]
2024-03-06 14:11 ` [pbs-devel] [PATCH proxmox-backup 1/3] server: sync: return `PullStats` for pull related methods Christian Ebner
2024-03-06 14:11 ` [pbs-devel] [PATCH proxmox-backup 2/3] fix #5285: api: sync: add job summary to task log Christian Ebner
2024-03-06 14:11 ` [pbs-devel] [PATCH proxmox-backup 3/3] server: sync: use HumanByte for task log output Christian Ebner
2024-03-06 17:29 ` [pbs-devel] [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job Max Carrara
2024-03-07 10:55   ` Max Carrara
2024-03-07 13:59 ` [pbs-devel] applied-series: " Thomas Lamprecht
2024-03-07 14:11   ` Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240306141153.419283-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal