public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit/proxmox-backup] ui: fix deleting dns servers
Date: Fri,  1 Mar 2024 10:03:39 +0100	[thread overview]
Message-ID: <20240301090341.1342682-1-d.csapak@proxmox.com> (raw)

by enabling 'deleteEmpty' for those form fields in pbs

will look into modifying the pve/pmg code to behave similarly as pbs
(possibly with an opt in flag), but this should be an immediate fix
for pbs for now.

when pve/pmg behaves similarly, we could drop the optional setting of
that again

proxmox-widget-toolkit:

Dominik Csapak (1):
  dns: optionally send delete for optional values

 src/node/DNSEdit.js | 6 ++++++
 src/node/DNSView.js | 4 ++++
 2 files changed, 10 insertions(+)

proxmox-backup:

Dominik Csapak (1):
  ui: fix deleting of optional dns server entries

 www/SystemConfiguration.js | 1 +
 1 file changed, 1 insertion(+)

-- 
2.30.2





             reply	other threads:[~2024-03-01  9:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  9:03 Dominik Csapak [this message]
2024-03-01  9:03 ` [pbs-devel] [PATCH widget-toolkit 1/1] dns: optionally send delete for optional values Dominik Csapak
2024-03-01 11:43   ` [pbs-devel] applied: " Thomas Lamprecht
2024-03-01  9:03 ` [pbs-devel] [PATCH proxmox-backup 1/1] ui: fix deleting of optional dns server entries Dominik Csapak
2024-03-04 13:53   ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301090341.1342682-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal