public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Lendl <git@stfl.dev>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v3 proxmox-backup 0/8] Add GC job status to datastore and global prune job view.
Date: Wed, 21 Feb 2024 10:58:43 +0100	[thread overview]
Message-ID: <20240221095843.488582-1-git@stfl.dev> (raw)
In-Reply-To: <20240208135953.2078165-1-s.lendl@proxmox.com>

From: Stefan Lendl <s.lendl@proxmox.com>

*Adding the missing Cover Letter here*

Fix #3217: Addition of a new tab "Prune & GC" in "Datastore" and not in each Datastore created
Fix #4723: add last, next run, status, duration to gc

Extends the garbage collection view to display in addition to the schedule:
 - State (of last run)
 - Duration (of last run)
 - Last Run Date
 - Next Run Date (if scheduled)
 - Removed Chunks (in last run)
 - Pending Chunks (as of last run)

In the Datastore global overview, the prune view is extended to show the same
details for all availible datastores also the ones without a gc-schedule.

Allows editing the schedule, showing the log of the last run and manually
running the gc job.  In the global view, by selecting the row of the datastore.

Adds a proxmox-backup-manager cli command to list all gc jobs
`proxmox-backup-manager garbage-collection list`


Changes v2 -> v3:
 - fixed indentation (how hard can it be?..)
 - added git trailers

Changes v1 -> v2:
 - sort imports
 - fix eslint warnings
 - update columns in GC Job view to fill the entire width
 - not include path PruneJobEdit (sent separatly)

This is based on a series from g.goller
Changes to g.goller's series:
 - rename endpoint from gc-info to gc-job-status
 - add list-all-gc-jobs endpoint
 - UI uses Grid (table) view instead of model grid
 - implement GC job view in global view

Stefan Lendl (8):
  api: garbage collect job status
  gc: global prune and gc job view
  gc: move datastore/PruneAndGC to config/PruneAndGC
  gc: hide datastore column in local gc view
  ui: order Prune&GC before SyncJobs
  cli: list gc jobs with proxmox-backup-manager
  gc: show removed and pending chunks of last run in ui
  gc: configure width and flex on GC Jobs columns

 pbs-api-types/src/datastore.rs    |  40 +++++
 src/api2/admin/datastore.rs       | 129 +++++++++++++++-
 src/api2/admin/gc.rs              |  57 +++++++
 src/api2/admin/mod.rs             |   2 +
 src/bin/proxmox-backup-manager.rs |  33 ++++
 www/Makefile                      |   4 +-
 www/Utils.js                      |   6 +-
 www/config/GCView.js              | 243 ++++++++++++++++++++++++++++++
 www/config/PruneAndGC.js          |  52 +++++++
 www/datastore/DataStoreList.js    |  11 +-
 www/datastore/Panel.js            |   3 +-
 www/datastore/PruneAndGC.js       | 133 ----------------
 www/window/GCJobEdit.js           |  28 ++++
 13 files changed, 593 insertions(+), 148 deletions(-)
 create mode 100644 src/api2/admin/gc.rs
 create mode 100644 www/config/GCView.js
 create mode 100644 www/config/PruneAndGC.js
 delete mode 100644 www/datastore/PruneAndGC.js
 create mode 100644 www/window/GCJobEdit.js

-- 
2.43.0





  parent reply	other threads:[~2024-02-21  9:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 13:59 [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE *** Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-03-21 10:23   ` Lukas Wagner
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 2/8] gc: global prune and gc job view Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 3/8] gc: move datastore/PruneAndGC to config/PruneAndGC Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 4/8] gc: hide datastore column in local gc view Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 5/8] ui: order Prune&GC before SyncJobs Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 6/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 7/8] gc: show removed and pending chunks of last run in ui Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 8/8] gc: configure width and flex on GC Jobs columns Stefan Lendl
2024-02-21  9:56 ` [pbs-devel] [PATCH v3 proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-02-21  9:58 ` Stefan Lendl [this message]
2024-03-07 13:16   ` Stefan Lendl
2024-03-21 10:24 ` [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE *** Lukas Wagner
2024-04-04 13:53 ` Stefan Lendl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240221095843.488582-1-git@stfl.dev \
    --to=git@stfl.dev \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal