From: Filip Schauer <f.schauer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v3 many] fix #4995: Include symlinks in zip file restore
Date: Thu, 14 Dec 2023 15:48:19 +0100 [thread overview]
Message-ID: <20231214144824.100616-1-f.schauer@proxmox.com> (raw)
Include symlinks when restoring files from a backup as a zip file.
Resulting ZIP files were successfully tested on Linux with: zipinfo,
unzip, unar
On Windows the extracted symlinks show up as regular files containing
the path to the destination. As far as I am aware Windows Explorer does
not support symlinks in ZIP files.
Changes since v2:
* Add a FileType enum and embed the symlink target into the enum.
* Add unit tests for ZipEncoder to the proxmox-compression crate
Changes since v1:
* Use P instead of &Path
* Fix compile error due to misplaced comma
* Check content before symlink_target, since regular files are more
common than symlinks
proxmox:
Filip Schauer (3):
compression: Add a FileType enum to ZipEntry
compression: Add support for symlinks in zip files
compression: Add unit tests for the ZipEncoder
proxmox-compression/Cargo.toml | 2 +-
proxmox-compression/src/zip.rs | 62 ++++++++++----
proxmox-compression/tests/zip.rs | 134 +++++++++++++++++++++++++++++++
3 files changed, 181 insertions(+), 17 deletions(-)
create mode 100644 proxmox-compression/tests/zip.rs
proxmox-backup:
Filip Schauer (2):
pxar: Adopt FileType enum when creating a ZipEntry
fix #4995: pxar: Include symlinks in zip file creation
pbs-client/src/pxar/extract.rs | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
--
2.39.2
next reply other threads:[~2023-12-14 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 14:48 Filip Schauer [this message]
2023-12-14 14:48 ` [pbs-devel] [PATCH v3 proxmox 1/3] compression: Add a FileType enum to ZipEntry Filip Schauer
2023-12-14 14:48 ` [pbs-devel] [PATCH v3 proxmox 2/3] compression: Add support for symlinks in zip files Filip Schauer
2023-12-20 13:20 ` Wolfgang Bumiller
2023-12-21 11:37 ` Filip Schauer
2023-12-21 12:03 ` Wolfgang Bumiller
2023-12-21 12:15 ` Filip Schauer
2023-12-21 12:11 ` Wolfgang Bumiller
2024-01-24 10:19 ` Filip Schauer
2023-12-14 14:48 ` [pbs-devel] [PATCH v3 proxmox 3/3] compression: Add unit tests for the ZipEncoder Filip Schauer
2023-12-14 14:48 ` [pbs-devel] [PATCH v3 backup 1/2] pxar: Adopt FileType enum when creating a ZipEntry Filip Schauer
2023-12-14 14:48 ` [pbs-devel] [PATCH v3 backup 2/2] fix #4995: pxar: Include symlinks in zip file creation Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214144824.100616-1-f.schauer@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox