From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox-backup 0/2] Fix DatastoreListSummary on limited permissions
Date: Mon, 11 Dec 2023 09:59:00 +0100 [thread overview]
Message-ID: <20231211085902.20747-1-g.goller@proxmox.com> (raw)
When the user has limited permissions on a datastore (e.g `NoAccess` on the whole
datastore and `DatastoreBackup` on a namespace inside the datastore) the Datastore
List shows weird values.
Instead of returning -1 we return an Option and handle missing values on the
frontend.
Changes version 2:
- Use u64 instead of i64, as value is never negative.
proxmox-backup:
Gabriel Goller (2):
ui: datastore summary handle non-existent values
status: use Option on avail/used datastore attrs
pbs-api-types/src/datastore.rs | 19 +++++++++++--------
src/api2/status.rs | 6 +++---
www/datastore/DataStoreListSummary.js | 20 ++++++++++++++------
3 files changed, 28 insertions(+), 17 deletions(-)
Summary over all repositories:
3 files changed, 28 insertions(+), 17 deletions(-)
--
murpp v0.4.0
next reply other threads:[~2023-12-11 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 8:59 Gabriel Goller [this message]
2023-12-11 8:59 ` [pbs-devel] [PATCH v2 proxmox-backup 1/2] ui: datastore summary handle non-existent values Gabriel Goller
2023-12-11 8:59 ` [pbs-devel] [PATCH v2 proxmox-backup 2/2] status: use Option on avail/used datastore attrs Gabriel Goller
2023-12-14 7:55 ` Thomas Lamprecht
2023-12-14 13:44 ` Gabriel Goller
2024-01-10 15:10 ` Gabriel Goller
2023-12-11 12:13 ` [pbs-devel] applied: [PATCH v2 proxmox-backup 0/2] Fix DatastoreListSummary on limited permissions Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211085902.20747-1-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox