From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs
Date: Thu, 30 Nov 2023 15:01:04 +0100 [thread overview]
Message-ID: <20231130140104.378248-1-c.ebner@proxmox.com> (raw)
Warn about a missing garbage collection schedule, prune job or verify
jobs configuration in summary panel of a datastore.
Show the number of prune/verify job configurations, if there are jobs
configured.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
www/datastore/Summary.js | 80 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index a932b4e0..6a63ca14 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -49,12 +49,19 @@ Ext.define('PBS.DataStoreInfo', {
usage: {},
stillbad: 0,
mountpoint: "",
+ gcScheduldeMsg: gettext('unknown'),
+ pruneJobMsg: gettext('unknown'),
+ verifyJobMsg: gettext('unknown'),
},
},
controller: {
xclass: 'Ext.app.ViewController',
+ fmtWarning: function(msg) {
+ return `<i class="fa fa-fw fa-lg fa-exclamation-circle warning"></i> ${msg}`;
+ },
+
onLoad: function(store, data, success) {
let me = this;
if (!success) {
@@ -101,6 +108,51 @@ Ext.define('PBS.DataStoreInfo', {
vm.set('ctcount', countstext(counts.ct));
vm.set('vmcount', countstext(counts.vm));
vm.set('hostcount', countstext(counts.host));
+
+ Proxmox.Utils.API2Request({
+ url: `/config/datastore/${me.view.datastore}`,
+ success: function(response) {
+ if (response.result.data['gc-schedule']) {
+ vm.set('gcScheduleMsg', gettext('configured'));
+ } else {
+ vm.set('gcScheduleMsg', me.fmtWarning(gettext('none configured')));
+ }
+ },
+ failure: function() {
+ vm.set('gcScheduleMsg', me.fmtWarning(gettext('unknown')));
+ }
+ });
+
+ Proxmox.Utils.API2Request({
+ url: `/admin/prune?store=${me.view.datastore}`,
+ success: function(response) {
+ let len = response.result.data.length;
+ if (len > 0) {
+ vm.set('pruneJobMsg', Ext.String.format(gettext('{0} configured'), len));
+ } else {
+ vm.set('pruneJobMsg', me.fmtWarning(gettext('none configured')));
+ }
+ },
+ failure: function() {
+ vm.set('pruneJobMsg', me.fmtWarning(gettext('unknown')));
+ }
+ });
+
+ Proxmox.Utils.API2Request({
+ url: `/admin/verify?store=${me.view.datastore}`,
+ success: function(response) {
+ console.log(response);
+ let len = response.result.data.length;
+ if (len > 0) {
+ vm.set('verifyJobMsg', Ext.String.format(gettext('{0} configured'), len));
+ } else {
+ vm.set('verifyJobMsg', me.fmtWarning(gettext('none configured')));
+ }
+ },
+ failure: function() {
+ vm.set('verifyJobMsg', me.fmtWarning(gettext('unknown')));
+ }
+ });
},
startStore: function() { this.store.startUpdate(); },
@@ -201,6 +253,34 @@ Ext.define('PBS.DataStoreInfo', {
visible: '{stillbad}',
},
},
+ {
+ title: gettext('Garbage Collection Schedule'),
+ printBar: false,
+ bind: {
+ data: {
+ text: '{gcScheduleMsg}',
+ },
+ },
+ padding: '10 0 0 0',
+ },
+ {
+ title: gettext('Prune Jobs'),
+ printBar: false,
+ bind: {
+ data: {
+ text: '{pruneJobMsg}',
+ },
+ },
+ },
+ {
+ title: gettext('Verify Jobs'),
+ printBar: false,
+ bind: {
+ data: {
+ text: '{verifyJobMsg}',
+ },
+ },
+ },
],
});
--
2.39.2
next reply other threads:[~2023-11-30 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:01 Christian Ebner [this message]
2023-12-04 15:42 ` Gabriel Goller
2023-12-04 16:09 ` Christian Ebner
2023-12-05 10:22 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130140104.378248-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox