From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] sync: fix recursive remote sync
Date: Thu, 30 Nov 2023 11:42:53 +0100 [thread overview]
Message-ID: <20231130104253.550177-1-f.gruenbichler@proxmox.com> (raw)
the snapshot pulling code always selected the "top" namespace of the source,
instead of the passed in namespace parameter.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/server/pull.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/server/pull.rs b/src/server/pull.rs
index 66ef333a..44d428fd 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -187,7 +187,7 @@ impl PullSource for RemoteSource {
async fn list_backup_dirs(
&self,
- _namespace: &BackupNamespace,
+ namespace: &BackupNamespace,
group: &BackupGroup,
worker: &WorkerTask,
) -> Result<Vec<BackupDir>, Error> {
@@ -198,8 +198,8 @@ impl PullSource for RemoteSource {
"backup-id": group.id,
});
- if !self.ns.is_root() {
- args["ns"] = serde_json::to_value(&self.ns)?;
+ if !namespace.is_root() {
+ args["ns"] = serde_json::to_value(&namespace)?;
}
self.client.login().await?;
--
2.39.2
next reply other threads:[~2023-11-30 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 10:42 Fabian Grünbichler [this message]
2023-11-30 10:57 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130104253.550177-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox