public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs'
Date: Thu, 30 Nov 2023 09:49:03 +0100	[thread overview]
Message-ID: <20231130084903.1189798-1-d.csapak@proxmox.com> (raw)

without any default value in the viewModel, the resulting url would be:

`<id>?destroy-data=<value>&keep-job-configs=`

which is missing the actual value, so add the default

Fixes: e9979a1a ("ui: add 'keep configs' checkbox to datastore removal window")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/datastore/OptionView.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 3ef4d3d5..6f1be969 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -10,6 +10,7 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
     viewModel: {
 	data: {
 	    'destroyData': 0,
+	    'keepJobConfigs': 0,
 	},
 	formulas: {
 	    destroyNote: get => get('destroyData')
-- 
2.30.2





             reply	other threads:[~2023-11-30  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  8:49 Dominik Csapak [this message]
2023-11-30  9:05 ` Fiona Ebner
2023-11-30  9:18 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231130084903.1189798-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal