public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-offline-mirror v2 0/3] improve pom multi-key handling
Date: Wed, 29 Nov 2023 15:51:13 +0100	[thread overview]
Message-ID: <20231129145116.202049-1-s.sterz@proxmox.com> (raw)

this patch series intends to improve the user experience when a user
adds multiple keys to one mirror and wants to use one medium to activate
multiple products. the first commit removes the `ProductType` trait that
has been moved to `proxmox-subscription` from pom. the second commit
handles media with muliple keys for muliple products more gracefully in
proxmox-offline-mirror-helper. it only tries to activate subscriptions
that have a matching server id. the finally commit just adds some
rustfmt clean ups.

changes since v1 @ (thanks to Fabian Grünbichler):

- moved to a hash map based approach when automatically selecting all
  applicable keys for the current system


Stefan Sterz (3):
  type: move `ProductType` enum to `proxmox-subscription`
  helper: improve handling of multiple keys when activating them
  offline mirror binary: rustfmt clean up

 src/bin/proxmox-offline-mirror-helper.rs      | 101 ++++++++++--------
 src/bin/proxmox-offline-mirror.rs             |  15 ++-
 src/bin/proxmox_offline_mirror_cmds/medium.rs |   4 +-
 .../subscription.rs                           |   4 +-
 src/config.rs                                 |   4 +-
 src/subscription.rs                           |   4 +-
 src/types.rs                                  |  44 +-------
 7 files changed, 75 insertions(+), 101 deletions(-)

--
2.39.2





             reply	other threads:[~2023-11-29 14:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 14:51 Stefan Sterz [this message]
2023-11-29 14:51 ` [pbs-devel] [PATCH proxmox-offline-mirror v2 1/3] type: move `ProductType` enum to `proxmox-subscription` Stefan Sterz
2023-11-29 14:51 ` [pbs-devel] [PATCH proxmox-offline-mirror v2 2/3] helper: improve handling of multiple keys when activating them Stefan Sterz
2023-11-29 14:51 ` [pbs-devel] [PATCH proxmox-offline-mirror v2 3/3] offline mirror binary: rustfmt clean up Stefan Sterz
2024-01-09  8:11 ` [pbs-devel] applied: [PATCH proxmox-offline-mirror v2 0/3] improve pom multi-key handling Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129145116.202049-1-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal