From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: add 'keep configs' checkbox to datastore removal window
Date: Wed, 29 Nov 2023 09:59:41 +0100 [thread overview]
Message-ID: <20231129085941.1132329-1-d.csapak@proxmox.com> (raw)
From: Hannes Laimer <h.laimer@proxmox.com>
... since the API already accepts a boolean for that.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
[ DC: actually send the option to the api ]
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
resent the old patch from hannes but added code to make it work,
hope thats ok @hannes
www/datastore/OptionView.js | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 448cd4b3..3ef4d3d5 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -34,7 +34,10 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
getParams: function() {
let viewModel = this.getViewModel();
- let params = { 'destroy-data': viewModel.get('destroyData') };
+ let params = {
+ 'destroy-data': viewModel.get('destroyData'),
+ 'keep-job-configs': viewModel.get('keepJobConfigs'),
+ };
return `?${Ext.Object.toQueryString(params)}`;
},
additionalItems: [{
@@ -45,6 +48,14 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
bind: {
value: '{destroyData}',
},
+ }, {
+ xtype: 'proxmoxcheckbox',
+ name: 'keep-job-configs',
+ boxLabel: gettext("Keep configured jobs and permissions"),
+ defaultValue: false,
+ bind: {
+ value: '{keepJobConfigs}',
+ },
}, {
xtype: 'component',
reference: 'noteCmp',
--
2.30.2
next reply other threads:[~2023-11-29 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 8:59 Dominik Csapak [this message]
2023-11-29 9:36 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129085941.1132329-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox