[pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job

[pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job

[Fiona Ebner]

when editing a local sync job, the field would be empty because of
this and not be set to the previously configured remote-store.

The binding is already used for the local datastore, not sure why it
should even be applied to the target where it might not even be valid.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Not familiar enough with the code, so sending as RFC.

 www/window/SyncJobEdit.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index d20def74..06d87bb2 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -225,9 +225,6 @@ Ext.define('PBS.window.SyncJobEdit', {
 			allowBlank: false,
 			autoSelect: false,
 			name: 'remote-store',
-			cbind: {
-			    datastore: '{datastore}',
-			},
 			listeners: {
 			    change: function(field, value) {
 				let me = this;
-- 
2.39.2

[pbs-devel] applied: [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job

[Thomas Lamprecht]

Am 28/11/2023 um 17:04 schrieb Fiona Ebner:
> when editing a local sync job, the field would be empty because of
> this and not be set to the previously configured remote-store.
> 
> The binding is already used for the local datastore, not sure why it
> should even be applied to the target where it might not even be valid.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Not familiar enough with the code, so sending as RFC.
> 
>  www/window/SyncJobEdit.js | 3 ---
>  1 file changed, 3 deletions(-)
> 
>

seems reasonable enough: applied, thanks!

Re: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job

[Hannes Laimer]

On 11/28/23 17:04, Fiona Ebner wrote:
> when editing a local sync job, the field would be empty because of
> this and not be set to the previously configured remote-store.
> 
do you mean when opening the edit window of a local sync job, or when
switching between local/remote? If the former, it's a bug, but I wasn't
able to reproduce it. If the later, it won't be possible to keep it when
switching, the store field is the same field for local and remote, as in
the job config.

But it probably would make sense to rename `remote-` to `source-` as we
did with the labels in the form.

> The binding is already used for the local datastore, not sure why it
> should even be applied to the target where it might not even be valid.
>The pbsRemoteStoreSelector needs to filter the datastores if it's local
since it shouldn't be possible to select the same source as target, 
that's how it knows which to leave out.

> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Not familiar enough with the code, so sending as RFC.
> 
>   www/window/SyncJobEdit.js | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index d20def74..06d87bb2 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -225,9 +225,6 @@ Ext.define('PBS.window.SyncJobEdit', {
>   			allowBlank: false,
>   			autoSelect: false,
>   			name: 'remote-store',
> -			cbind: {
> -			    datastore: '{datastore}',
> -			},
>   			listeners: {
>   			    change: function(field, value) {
>   				let me = this;

Re: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job

[Fiona Ebner]

Am 29.11.23 um 07:54 schrieb Hannes Laimer:
> On 11/28/23 17:04, Fiona Ebner wrote:
>> when editing a local sync job, the field would be empty because of
>> this and not be set to the previously configured remote-store.
>>
> do you mean when opening the edit window of a local sync job, or when
> switching between local/remote? If the former, it's a bug, but I wasn't
> able to reproduce it. If the later, it won't be possible to keep it when
> switching, the store field is the same field for local and remote, as in
> the job config.
> 

The former with proxmox-backup-server=3.0.5-1. Happens with both Firefox
and Chromium for me.

Re: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job

[Fiona Ebner]

Am 29.11.23 um 08:42 schrieb Fiona Ebner:
> Am 29.11.23 um 07:54 schrieb Hannes Laimer:
>> On 11/28/23 17:04, Fiona Ebner wrote:
>>> when editing a local sync job, the field would be empty because of
>>> this and not be set to the previously configured remote-store.
>>>
>> do you mean when opening the edit window of a local sync job, or when
>> switching between local/remote? If the former, it's a bug, but I wasn't
>> able to reproduce it. If the later, it won't be possible to keep it when
>> switching, the store field is the same field for local and remote, as in
>> the job config.
>>
> 
> The former with proxmox-backup-server=3.0.5-1. Happens with both Firefox
> and Chromium for me.

As discussed off-list with Hannes, there already is a fix for this in
current master: fbee4799 ("ui: fix local sync job edit") and I
completely missed that this was the reason it worked rather than my
change when testing. So my change should be reverted, sorry about that!