public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job
Date: Tue, 28 Nov 2023 17:04:15 +0100	[thread overview]
Message-ID: <20231128160415.81314-1-f.ebner@proxmox.com> (raw)

when editing a local sync job, the field would be empty because of
this and not be set to the previously configured remote-store.

The binding is already used for the local datastore, not sure why it
should even be applied to the target where it might not even be valid.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Not familiar enough with the code, so sending as RFC.

 www/window/SyncJobEdit.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index d20def74..06d87bb2 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -225,9 +225,6 @@ Ext.define('PBS.window.SyncJobEdit', {
 			allowBlank: false,
 			autoSelect: false,
 			name: 'remote-store',
-			cbind: {
-			    datastore: '{datastore}',
-			},
 			listeners: {
 			    change: function(field, value) {
 				let me = this;
-- 
2.39.2





             reply	other threads:[~2023-11-28 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 16:04 Fiona Ebner [this message]
2023-11-28 17:52 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-29  6:54 ` [pbs-devel] " Hannes Laimer
2023-11-29  7:42   ` Fiona Ebner
2023-11-29  8:02     ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128160415.81314-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal