public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit
Date: Tue, 28 Nov 2023 14:01:24 +0100	[thread overview]
Message-ID: <20231128130124.258148-1-h.laimer@proxmox.com> (raw)

... since the store field was cleared when the window opened.

Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Fixes: 9039d6709e375f37bb8a21680f6fefb18ee87ab3
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
the fie

 www/form/RemoteTargetSelector.js | 4 ++--
 www/window/SyncJobEdit.js        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/form/RemoteTargetSelector.js b/www/form/RemoteTargetSelector.js
index 9ea802d1..3d066f54 100644
--- a/www/form/RemoteTargetSelector.js
+++ b/www/form/RemoteTargetSelector.js
@@ -33,10 +33,10 @@ Ext.define('PBS.form.RemoteStoreSelector', {
 	// do nothing.
     },
 
-    setRemote: function(remote) {
+    setRemote: function(remote, forceReload = false) {
 	let me = this;
 
-	if (me.remote === remote) {
+	if (!forceReload && me.remote === remote) {
 	    return;
 	}
 
diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index dbd53178..d20def74 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -181,15 +181,15 @@ Ext.define('PBS.window.SyncJobEdit', {
 				remoteField.setDisabled(isLocalSync);
 				storeField.setDisabled(!isLocalSync && !remoteField.value);
 				if (isLocalSync === !!remoteField.value) {
-				    storeField.clearValue();
 				    remoteField.clearValue();
 				}
 
 				if (isLocalSync) {
 				    storeField.setDisabled(false);
 				    rateLimitField.setValue(null);
-				    storeField.setRemote(null);
+				    storeField.setRemote(null, true);
 				} else {
+				    storeField.clearValue();
 				    remoteField.validate();
 				}
 			    },
-- 
2.39.2





             reply	other threads:[~2023-11-28 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 13:01 Hannes Laimer [this message]
2023-11-28 13:02 ` Lukas Wagner
2023-11-28 13:13 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128130124.258148-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal