public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use
@ 2023-11-28 11:11 Alexander Zeidler
  2023-11-28 11:11 ` [pbs-devel] [PATCH proxmox-backup 2/2] docs: fix formatting Alexander Zeidler
  2023-11-28 13:47 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Zeidler @ 2023-11-28 11:11 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
 docs/installation.rst | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/docs/installation.rst b/docs/installation.rst
index 44c28067..55eddfb4 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -60,8 +60,8 @@ standard Debian installation. After configuring the
 
 .. code-block:: console
 
-  # apt-get update
-  # apt-get install proxmox-backup-server
+  # apt update
+  # apt install proxmox-backup-server
 
 The above commands keep the current (Debian) kernel and install a minimal
 set of required packages.
@@ -71,8 +71,8 @@ does, please use the following:
 
 .. code-block:: console
 
-  # apt-get update
-  # apt-get install proxmox-backup
+  # apt update
+  # apt install proxmox-backup
 
 This will install all required packages, the Proxmox kernel with ZFS_
 support, and a set of common and useful packages.
@@ -95,8 +95,8 @@ After configuring the
 
 .. code-block:: console
 
-  # apt-get update
-  # apt-get install proxmox-backup-server
+  # apt update
+  # apt install proxmox-backup-server
 
 .. caution:: Installing the backup server directly on the hypervisor
    is not recommended. It is safer to use a separate physical
@@ -119,8 +119,8 @@ you need to run:
 
 .. code-block:: console
 
-  # apt-get update
-  # apt-get install proxmox-backup-client
+  # apt update
+  # apt install proxmox-backup-client
 
 
 .. note:: The client-only repository should be usable by most recent Debian and
-- 
2.39.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pbs-devel] [PATCH proxmox-backup 2/2] docs: fix formatting
  2023-11-28 11:11 [pbs-devel] [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use Alexander Zeidler
@ 2023-11-28 11:11 ` Alexander Zeidler
  2023-11-28 13:47 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Zeidler @ 2023-11-28 11:11 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
 docs/local-zfs.rst      | 22 +++++++++++-----------
 docs/system-booting.rst |  4 ++--
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/docs/local-zfs.rst b/docs/local-zfs.rst
index b124fc65..f079adb0 100644
--- a/docs/local-zfs.rst
+++ b/docs/local-zfs.rst
@@ -290,17 +290,17 @@ an editor of your choice and add the following line:
   vm.swappiness = 10
 
 .. table:: Linux kernel `swappiness` parameter values
-  :widths:auto
-
-  ====================  ===============================================================
-   Value                Strategy
-  ====================  ===============================================================
-   vm.swappiness = 0    The kernel will swap only to avoid an 'out of memory' condition
-   vm.swappiness = 1    Minimum amount of swapping without disabling it entirely.
-   vm.swappiness = 10   Sometimes recommended to improve performance when sufficient memory exists in a system.
-   vm.swappiness = 60   The default value.
-   vm.swappiness = 100  The kernel will swap aggressively.
-  ====================  ===============================================================
+  :widths: 1, 3
+
+  ===================  ===============================================================
+  Value                Strategy
+  ===================  ===============================================================
+  vm.swappiness = 0    The kernel will swap only to avoid an 'out of memory' condition
+  vm.swappiness = 1    Minimum amount of swapping without disabling it entirely.
+  vm.swappiness = 10   Sometimes recommended to improve performance when sufficient memory exists in a system.
+  vm.swappiness = 60   The default value.
+  vm.swappiness = 100  The kernel will swap aggressively.
+  ===================  ===============================================================
 
 ZFS compression
 ^^^^^^^^^^^^^^^
diff --git a/docs/system-booting.rst b/docs/system-booting.rst
index 0b1043bf..96c3458c 100644
--- a/docs/system-booting.rst
+++ b/docs/system-booting.rst
@@ -86,8 +86,8 @@ Setting up a New Partition for use as Synced ESP
 To format and initialize a partition as synced ESP, for example, after replacing a
 failed vdev in an rpool, ``proxmox-boot-tool`` from ``proxmox-kernel-helper`` can be used.
 
-WARNING: the ``format`` command will format the ``<partition>``. Make sure to pass
-in the right device/partition!
+.. WARNING:: the ``format`` command will format the ``<partition>``. Make sure
+   to pass in the right device/partition!
 
 For example, to format an empty partition ``/dev/sda2`` as ESP, run the following:
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use
  2023-11-28 11:11 [pbs-devel] [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use Alexander Zeidler
  2023-11-28 11:11 ` [pbs-devel] [PATCH proxmox-backup 2/2] docs: fix formatting Alexander Zeidler
@ 2023-11-28 13:47 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-11-28 13:47 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Alexander Zeidler

Am 28/11/2023 um 12:11 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  docs/installation.rst | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
>

applied both patches, thanks!

Second one needed a three-way merge to apply though.

FWIW and a pre-existing thing: having the swappiness values explained
in the middle of ZFS docs make not much sense, that should get moved to
a non-FS specific section..




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-28 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-28 11:11 [pbs-devel] [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use Alexander Zeidler
2023-11-28 11:11 ` [pbs-devel] [PATCH proxmox-backup 2/2] docs: fix formatting Alexander Zeidler
2023-11-28 13:47 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] docs: s/apt-get/apt due to interactive use Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal