[pbs-devel] [PATCH proxmox-backup 0/2] local sync follow-up

[pbs-devel] [PATCH proxmox-backup 0/2] local sync follow-up

[Hannes Laimer]

two small follow-ups for local sync

Hannes Laimer (2):
  ui: fix sync job initial loading of local datastores
  config: don't allow creation of sync job to same datastore

 src/api2/config/sync.rs   | 4 ++++
 www/window/SyncJobEdit.js | 1 +
 2 files changed, 5 insertions(+)

-- 
2.39.2

[pbs-devel] [PATCH proxmox-backup 1/2] ui: fix sync job initial loading of local datastores

[Hannes Laimer]

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/window/SyncJobEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index 282f16a3..dbd53178 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -188,6 +188,7 @@ Ext.define('PBS.window.SyncJobEdit', {
 				if (isLocalSync) {
 				    storeField.setDisabled(false);
 				    rateLimitField.setValue(null);
+				    storeField.setRemote(null);
 				} else {
 				    remoteField.validate();
 				}
-- 
2.39.2

[pbs-devel] [PATCH proxmox-backup 2/2] config: don't allow creation of sync job to same datastore

[Hannes Laimer]

Reported-by: Gabriel Goller <g.goller@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---

 src/api2/config/sync.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs
index 21634bd5..ea0e08f1 100644
--- a/src/api2/config/sync.rs
+++ b/src/api2/config/sync.rs
@@ -141,6 +141,10 @@ pub fn create_sync_job(
         bail!("permission check failed");
     }
 
+    if config.remote.is_none() && config.store.eq(&config.remote_store) {
+        bail!("source and target datastore can't be the same");
+    }
+
     if let Some(max_depth) = config.max_depth {
         if let Some(ref ns) = config.ns {
             ns.check_max_depth(max_depth)?;
-- 
2.39.2

[pbs-devel] applied-series: [PATCH proxmox-backup 0/2] local sync follow-up

[Thomas Lamprecht]

On 27.11.23 12:59, Hannes Laimer wrote:
> two small follow-ups for local sync
> 
> Hannes Laimer (2):
>   ui: fix sync job initial loading of local datastores
>   config: don't allow creation of sync job to same datastore
> 
>  src/api2/config/sync.rs   | 4 ++++
>  www/window/SyncJobEdit.js | 1 +
>  2 files changed, 5 insertions(+)
> 


applied series, thanks!