public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] client: change anyhow Error display representation
@ 2023-11-25 10:13 Christian Ebner
  2023-11-25 15:10 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2023-11-25 10:13 UTC (permalink / raw)
  To: pbs-devel

Improve error message output by showing the full Error context, using
the alternate selector '{:#}" [0].
Without this, only the outermost context is displayed, which in case
of pxar extraction errors is mostly not enough to find the underlying
issue.

[0] https://docs.rs/anyhow/1.0.69/anyhow/struct.Error.html#display-representations

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Current error context just gives to little information, as for example
see here https://forum.proxmox.com/threads/136341/

 proxmox-backup-client/src/main.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index 1a13291a..9b680f62 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -1453,7 +1453,7 @@ async fn restore(
                 },
                 options,
             )
-            .map_err(|err| format_err!("error extracting archive - {}", err))?;
+            .map_err(|err| format_err!("error extracting archive - {:#}", err))?;
         } else {
             let mut writer = std::fs::OpenOptions::new()
                 .write(true)
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-25 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-25 10:13 [pbs-devel] [PATCH proxmox-backup] client: change anyhow Error display representation Christian Ebner
2023-11-25 15:10 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal