From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v6 0/6] local sync-jobs
Date: Tue, 21 Nov 2023 15:31:49 +0100 [thread overview]
Message-ID: <20231121143155.370916-1-h.laimer@proxmox.com> (raw)
Add support for local sync. SyncJobs without a remote are considered local, and
use a different logic for pulling. In the course of adding the extra pull logic,
the pull code was rewritten to basically be source independent. Also cli
completion and the UI was updated to allow Remotes in SyncJobs to be optional.
v6: thanks @Gabriel and @Thomas for the feedback
* disallow sync to same datastore
* ui: fix not checked checkbox
* ui: don't allow same datastore as source as the target
* ui: render empty remote-id's the same way namespaces are
* reorder patches, do config/api changes last
(so instead of an Option pretending to be a String, we have a String
pretending to be an Option, avoiding problems in intermediate patches)
v5: thanks @Thomas for the feedback
* ui: add radio buttons to make local vs remote more clear
* move ui patch to the end + api2 -> api
v4: thanks @Wolfgang and @Lukas for the feedback
* ui: disable rate limit for local sync jobs
* ui: rename `Source Remote` -> `Source PBS`
* update SYNC_JOB_WORKER_ID_REGEX, use '-' as remote for local
* fix problme with groups not being synced to the correct ns
* add check for source == target
* moved two changes from patch 3 to patch 1
v3: thanks @Fabian and @Wolfang for the feedback
* remove enums for Local/Remote
* use traits, pull logic now expects a `dyn PullSource`(or `dyn PullReader`)
* add lock to dir for local sync
* split refactoring of pull logic and implementation of
local pulling into two commits
v2: thanks @Fabian for the feedback
* make pull logic more source independent
Hannes Laimer (6):
accept a ref to a HttpClient
pull: refactor pulling from a datastore
pull: add support for pulling from local datastore
manager: add completion for opt. Remote in SyncJob
api: make Remote for SyncJob optional
ui: add support for optional Remote in SyncJob
Cargo.toml | 2 +
examples/download-speed.rs | 2 +-
pbs-api-types/src/jobs.rs | 9 +-
pbs-client/src/backup_reader.rs | 2 +-
pbs-datastore/src/read_chunk.rs | 2 +-
proxmox-backup-client/src/catalog.rs | 4 +-
proxmox-backup-client/src/main.rs | 2 +-
proxmox-backup-client/src/mount.rs | 2 +-
proxmox-file-restore/src/main.rs | 4 +-
src/api2/config/remote.rs | 16 +-
src/api2/config/sync.rs | 41 +-
src/api2/node/tasks.rs | 3 +-
src/api2/pull.rs | 60 +-
src/bin/proxmox-backup-manager.rs | 67 +-
src/bin/proxmox_backup_debug/diff.rs | 2 +-
src/server/email_notifications.rs | 18 +-
src/server/pull.rs | 1073 ++++++++++++++++----------
www/Utils.js | 5 +
www/config/SyncView.js | 1 +
www/form/RemoteTargetSelector.js | 36 +-
www/window/SyncJobEdit.js | 73 +-
21 files changed, 934 insertions(+), 490 deletions(-)
--
2.39.2
next reply other threads:[~2023-11-21 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 14:31 Hannes Laimer [this message]
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 1/6] accept a ref to a HttpClient Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 2/6] pull: refactor pulling from a datastore Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 3/6] pull: add support for pulling from local datastore Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 4/6] manager: add completion for opt. Remote in SyncJob Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 5/6] api: make Remote for SyncJob optional Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 6/6] ui: add support for optional Remote in SyncJob Hannes Laimer
2023-11-24 10:36 ` Lukas Wagner
2023-11-25 16:16 ` Thomas Lamprecht
2023-11-22 10:14 ` [pbs-devel] [PATCH proxmox-backup v6 0/6] local sync-jobs Gabriel Goller
2023-11-24 10:38 ` Lukas Wagner
2023-11-25 16:14 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121143155.370916-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox