From: Maximiliano Sandoval R <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 2/2] router: Use safe wrapper for libc::isatty
Date: Fri, 17 Nov 2023 13:37:39 +0100 [thread overview]
Message-ID: <20231117123739.157277-3-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20231117123739.157277-1-m.sandoval@proxmox.com>
Signed-off-by: Maximiliano Sandoval R <m.sandoval@proxmox.com>
---
proxmox-router/src/cli/text_table.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-router/src/cli/text_table.rs b/proxmox-router/src/cli/text_table.rs
index 9bc7210..3368605 100644
--- a/proxmox-router/src/cli/text_table.rs
+++ b/proxmox-router/src/cli/text_table.rs
@@ -1,4 +1,4 @@
-use std::io::Write;
+use std::io::{IsTerminal, Write};
use anyhow::{bail, Error};
use serde_json::Value;
@@ -245,7 +245,7 @@ impl TableFormatOptions {
pub fn new() -> Self {
let mut me = Self::default();
- let is_tty = unsafe { libc::isatty(libc::STDOUT_FILENO) == 1 };
+ let is_tty = std::io::stdout().is_terminal();
if is_tty {
let (_rows, columns) = stdout_terminal_size();
--
2.39.2
prev parent reply other threads:[~2023-11-17 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:37 [pbs-devel] [PATCH proxmox 0/2] Use IsTerminal trait Maximiliano Sandoval R
2023-11-17 12:37 ` [pbs-devel] [PATCH proxmox 1/2] sys: Use safe wrapper for libc::isatty Maximiliano Sandoval R
2023-11-19 15:09 ` Thomas Lamprecht
2023-11-20 7:54 ` Fabian Grünbichler
2023-11-20 7:55 ` Maximiliano Sandoval
2023-11-17 12:37 ` Maximiliano Sandoval R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117123739.157277-3-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox