public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH offline-mirror/proxmox/backup-server 0/6] improve pom multi-key handling and pbs key check
Date: Thu,  9 Nov 2023 16:33:57 +0100	[thread overview]
Message-ID: <20231109153403.529870-1-s.sterz@proxmox.com> (raw)

this patch series intends to improve the usability of the
`proxmox-offline-mirror-helper`. it also refactors the handling of the
`ProductType` type. by moving it into the `proxmox-subscription` crate, it is
possible to check the product type consistently accross products. this enables
us to also add a check for the product type to the `subscription
set-offline-key` command in pbs.

the first and third patches move the `ProductType` trait from pom into the
`proxmox-subscription`. the second patch also exposes a `get_next_due_date()`
function for the `SubscriptionInfo` type. these patches need to be applied for
the other patches to work.

the third patch adapts pom's handling of multi-key key-media. previously there
was a bug where pom did not check if the subscription's server id matche the
current system's. this commit fixes that and also adds some more convenience
for systems that need keys for multiple products (e. g. a pve+pbs host). it
also filters the keys by server id that are shown to cli users when using the
interactive `setup` command.

the fifth commit is just a rustfmt clean up for pom. the sixth commit adds a
check to pbs that makes sure an offline subscription that is applied throuh the
manager's `subscription set-offline-key` command is actually a pbs
subscription.

Stefan Sterz (2) @ proxmox:
  type: move `ProductType` type to `proxmox-subscription` from pom
  subscription: expose the `next_due_date` as an `i64`

 proxmox-subscription/src/lib.rs               |  4 +-
 proxmox-subscription/src/subscription_info.rs | 58 ++++++++++++++++++-
 2 files changed, 60 insertions(+), 2 deletions(-)

Stefan Sterz (3) @ proxmox-offline-mirror:
  type: move `ProductType` enum to `proxmox-subscription`
  helper: improve handling of multiple keys when activating them
  offline mirror binary: rustfmt clean up

 src/bin/proxmox-offline-mirror-helper.rs      | 101 +++++++++++-------
 src/bin/proxmox-offline-mirror.rs             |  15 ++-
 src/bin/proxmox_offline_mirror_cmds/medium.rs |   4 +-
 .../subscription.rs                           |   4 +-
 src/config.rs                                 |   4 +-
 src/subscription.rs                           |   4 +-
 src/types.rs                                  |  44 +-------
 7 files changed, 77 insertions(+), 99 deletions(-)

Stefan Sterz (1) @ proxmox-backup:
  manager: check if offline subscription is for the correct product

 src/bin/proxmox_backup_manager/subscription.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--
2.39.2





             reply	other threads:[~2023-11-09 15:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 15:33 Stefan Sterz [this message]
2023-11-09 15:33 ` [pbs-devel] [PATCH proxmox 1/6] type: move `ProductType` type to `proxmox-subscription` from pom Stefan Sterz
2023-11-27 13:12   ` [pbs-devel] applied: " Fabian Grünbichler
2023-11-09 15:33 ` [pbs-devel] [PATCH proxmox 2/6] subscription: expose the `next_due_date` as an `i64` Stefan Sterz
2023-11-27 13:12   ` [pbs-devel] applied: " Fabian Grünbichler
2023-11-09 15:34 ` [pbs-devel] [PATCH proxmox-offline-mirror 3/6] type: move `ProductType` enum to `proxmox-subscription` Stefan Sterz
2023-11-09 15:34 ` [pbs-devel] [PATCH proxmox-offline-mirror 4/6] helper: improve handling of multiple keys when activating them Stefan Sterz
2023-11-27 13:10   ` Fabian Grünbichler
2023-11-09 15:34 ` [pbs-devel] [PATCH proxmox-offline-mirror 5/6] offline mirror binary: rustfmt clean up Stefan Sterz
2023-11-09 15:34 ` [pbs-devel] [PATCH proxmox-backup 6/6] manager: check if offline subscription is for the correct product Stefan Sterz
2023-11-27 13:14   ` [pbs-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109153403.529870-1-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal