public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/3] fix #4315: datastore: Exclude entries from sync
Date: Mon, 23 Oct 2023 17:42:59 +0200	[thread overview]
Message-ID: <20231023154302.2558918-1-p.hufnagl@proxmox.com> (raw)

This allows to use Group Filter for sync jobs so matches can not just be
included but also excluded. For this the "group-filter" configuration
syntax has been extended with an optional "behaviour" parameter.
this can be "include" or "exclude". Filter will be applied in the order
of the config file. For example config entries could look like this:

Will continue include the match for compatiblity.
        group-filter regex:.*

Will exclude the match from the sync job.
        group-filter exclude:regex:.*10[1-3].*

Will include the match to the sync job.
        group-filter include:regex:.*10[2-3].*

So after this 3 lines, 100, 202 and 103 would be included but 101
would be excluded.

Since obmitting the behaviour parameter will continue to include the
match, this parameter is not intendet to be set to "include" by the GUI
or other tooling. Its just there to make manual configuration edits more
forgiving.

Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
---

Philipp Hufnagl (3):
  fix #4315: jobs: modify GroupFilter so include/exclude is tracked
  ui: Show if Filter includes or excludes
  docs: document new include/exclude paramenter

 docs/managing-remotes.rst      |  7 +++++
 pbs-api-types/src/datastore.rs | 11 +++----
 pbs-api-types/src/jobs.rs      | 49 +++++++++++++++++++++--------
 src/api2/tape/backup.rs        |  8 ++++-
 src/server/pull.rs             |  8 ++++-
 www/form/GroupFilter.js        | 57 +++++++++++++++++++++++++++++++---
 6 files changed, 115 insertions(+), 25 deletions(-)

-- 
2.39.2





             reply	other threads:[~2023-10-23 15:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 15:42 Philipp Hufnagl [this message]
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2023-10-24  9:18   ` Lukas Wagner
2023-10-24  9:54     ` Philipp Hufnagl
2023-10-24 10:43       ` Lukas Wagner
2023-10-24 14:32         ` Philipp Hufnagl
2023-10-25 13:33           ` Thomas Lamprecht
2023-10-25 15:07             ` Philipp Hufnagl
2023-10-25 15:45               ` Thomas Lamprecht
2023-11-07  7:43                 ` Wolfgang Bumiller
2023-11-07  7:55                   ` Thomas Lamprecht
2023-11-07  8:26                     ` Wolfgang Bumiller
2023-11-07  9:01                       ` Dominik Csapak
2023-11-07 11:10                         ` Thomas Lamprecht
2023-11-07 11:07                       ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: Show if Filter includes or excludes Philipp Hufnagl
2023-10-24 12:20   ` Lukas Wagner
2023-10-24 12:27   ` Lukas Wagner
2023-10-24 12:36     ` Philipp Hufnagl
2023-10-24 14:09       ` Philipp Hufnagl
2023-10-24 14:12         ` Lukas Wagner
2023-10-27  9:29           ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 3/3] docs: document new include/exclude paramenter Philipp Hufnagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231023154302.2558918-1-p.hufnagl@proxmox.com \
    --to=p.hufnagl@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal