public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH pve-manager] ui: align spinner to the left, added label
Date: Wed, 18 Oct 2023 12:08:58 +0200	[thread overview]
Message-ID: <20231018100858.56184-3-g.goller@proxmox.com> (raw)
In-Reply-To: <20231018100858.56184-1-g.goller@proxmox.com>

Moved the spinner in the task and replication view to the left, so it is
aligned correctly with the 'OK' and 'Error: ...' text.
Removed 'x-grid-row-loading' class as it has been moved to the
`proxmox-widget-toolkit` repo.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 www/css/ext6-pve.css             | 6 ------
 www/manager6/dc/Tasks.js         | 3 ++-
 www/manager6/grid/Replication.js | 4 ++--
 3 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css
index edae462b..237500bb 100644
--- a/www/css/ext6-pve.css
+++ b/www/css/ext6-pve.css
@@ -78,12 +78,6 @@
     content: "\f115";
 }
 
-/* loading in task list */
-.x-grid-row-loading {
-    background: no-repeat center center;
-    background-image:url(../ext6/theme-crisp/resources/images/loadmask/loading.gif);
-}
-
 /* console icon in task list */
 .x-grid-row-console {
     background: no-repeat center center;
diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js
index 5344ede4..1a35c183 100644
--- a/www/manager6/dc/Tasks.js
+++ b/www/manager6/dc/Tasks.js
@@ -120,7 +120,8 @@ Ext.define('PVE.dc.Tasks', {
 		    renderer: function(value, metaData, record) {
 			if (record.data.pid) {
 			    if (record.data.type !== "vncproxy") {
-				metaData.tdCls = "x-grid-row-loading";
+				metaData.tdCls = "x-grid-row-loading-left";
+				return `<img src="js/extjs/theme-crisp/resources/images/loadmask/loading.gif" />${gettext('Running')}`;
 			    }
 			    return "";
 			}
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index 30cd6718..29af4aa3 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -329,8 +329,8 @@ Ext.define('PVE.grid.ReplicaView', {
 		    flex: 1,
 		    renderer: function(value, metadata, record) {
 			if (record.data.pid) {
-			    metadata.tdCls = 'x-grid-row-loading';
-			    return '';
+			    metadata.tdCls = "x-grid-row-loading-left";
+			    return `<img src="js/extjs/theme-crisp/resources/images/loadmask/loading.gif" />${gettext('Running')}`;
 			}
 
 			let icons = [], states = [];
-- 
2.39.2





      parent reply	other threads:[~2023-10-18 10:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 10:08 [pbs-devel] [PATCH widget-toolkit 2/2] ui: moved common loading spinner classes Gabriel Goller
2023-10-18 10:08 ` [pbs-devel] [PATCH proxmox-backup] ui: align loading spinner to the left, added label Gabriel Goller
2023-10-18 10:08 ` Gabriel Goller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018100858.56184-3-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal