From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: align loading spinner to the left, added label
Date: Wed, 18 Oct 2023 12:08:57 +0200 [thread overview]
Message-ID: <20231018100858.56184-2-g.goller@proxmox.com> (raw)
In-Reply-To: <20231018100858.56184-1-g.goller@proxmox.com>
Moved the spinner in the Task View (and in other components that show
the status) to the left (`text-align: left`) so that the style matches
with the 'OK' and 'Error: ...' text shown in that grid-row. Also added a
label 'Running' (considers translations).
Note: The `x-grid-row-loading` and new `x-grid-row-loading-left` classes have
been moved to the `proxmox-widget-toolkit` repo.
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
www/Utils.js | 4 ++--
www/css/ext6-pbs.css | 6 ------
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/www/Utils.js b/www/Utils.js
index 2eca600e..e92af6c6 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -205,8 +205,8 @@ Ext.define('PBS.Utils', {
}
if (!record.data['last-run-endtime']) {
- metadata.tdCls = 'x-grid-row-loading';
- return '';
+ metadata.tdCls = 'x-grid-row-loading-left';
+ return `<img src="extjs/theme-crisp/resources/images/loadmask/loading.gif" />${gettext('Running')}`;
}
let parsed = Proxmox.Utils.parse_task_status(value);
diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 5fd65d25..a437ffae 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -79,12 +79,6 @@
color: black;
}
-/* loading in task list */
-.x-grid-row-loading {
- background: no-repeat center center;
- background-image:url(../extjs/theme-crisp/resources/images/loadmask/loading.gif);
-}
-
/* displayfield minheight is wrong */
.x-form-display-field-default {
min-height: 20px;
--
2.39.2
next prev parent reply other threads:[~2023-10-18 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:08 [pbs-devel] [PATCH widget-toolkit 2/2] ui: moved common loading spinner classes Gabriel Goller
2023-10-18 10:08 ` Gabriel Goller [this message]
2023-10-18 10:08 ` [pbs-devel] [PATCH pve-manager] ui: align spinner to the left, added label Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018100858.56184-2-g.goller@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox