[pbs-devel] [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed

[pbs-devel] [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed

[Hannes Laimer]

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 3c68b919..0cb8f4c2 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -892,7 +892,7 @@ impl DataStore {
                 (Some(inner), None) => bail!("unexpected error on datastore traversal: {inner}"),
             };
             if inner.kind() == io::ErrorKind::PermissionDenied {
-                if err.depth() == 0 && path.ends_with("lost+found") {
+                if err.depth() <= 1 && path.ends_with("lost+found") {
                     // allow skipping ext4 fsck-directory on EPERM only, otherwise we might prune
                     // too many chunks. E.g., if users messed up with owner/perms on a rsync
                     return Ok(());
-- 
2.39.2

[pbs-devel] applied: [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed

[Fabian Grünbichler]

with Fixes: and a follow-up improving the confusing comment there ;)

On September 12, 2023 11:18 am, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  pbs-datastore/src/datastore.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
> index 3c68b919..0cb8f4c2 100644
> --- a/pbs-datastore/src/datastore.rs
> +++ b/pbs-datastore/src/datastore.rs
> @@ -892,7 +892,7 @@ impl DataStore {
>                  (Some(inner), None) => bail!("unexpected error on datastore traversal: {inner}"),
>              };
>              if inner.kind() == io::ErrorKind::PermissionDenied {
> -                if err.depth() == 0 && path.ends_with("lost+found") {
> +                if err.depth() <= 1 && path.ends_with("lost+found") {
>                      // allow skipping ext4 fsck-directory on EPERM only, otherwise we might prune
>                      // too many chunks. E.g., if users messed up with owner/perms on a rsync
>                      return Ok(());
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>