* [pbs-devel] [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed
@ 2023-09-12 9:18 Hannes Laimer
2023-09-12 9:30 ` [pbs-devel] applied: " Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2023-09-12 9:18 UTC (permalink / raw)
To: pbs-devel
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
pbs-datastore/src/datastore.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 3c68b919..0cb8f4c2 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -892,7 +892,7 @@ impl DataStore {
(Some(inner), None) => bail!("unexpected error on datastore traversal: {inner}"),
};
if inner.kind() == io::ErrorKind::PermissionDenied {
- if err.depth() == 0 && path.ends_with("lost+found") {
+ if err.depth() <= 1 && path.ends_with("lost+found") {
// allow skipping ext4 fsck-directory on EPERM only, otherwise we might prune
// too many chunks. E.g., if users messed up with owner/perms on a rsync
return Ok(());
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed
2023-09-12 9:18 [pbs-devel] [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed Hannes Laimer
@ 2023-09-12 9:30 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2023-09-12 9:30 UTC (permalink / raw)
To: Proxmox Backup Server development discussion
with Fixes: and a follow-up improving the confusing comment there ;)
On September 12, 2023 11:18 am, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> pbs-datastore/src/datastore.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
> index 3c68b919..0cb8f4c2 100644
> --- a/pbs-datastore/src/datastore.rs
> +++ b/pbs-datastore/src/datastore.rs
> @@ -892,7 +892,7 @@ impl DataStore {
> (Some(inner), None) => bail!("unexpected error on datastore traversal: {inner}"),
> };
> if inner.kind() == io::ErrorKind::PermissionDenied {
> - if err.depth() == 0 && path.ends_with("lost+found") {
> + if err.depth() <= 1 && path.ends_with("lost+found") {
> // allow skipping ext4 fsck-directory on EPERM only, otherwise we might prune
> // too many chunks. E.g., if users messed up with owner/perms on a rsync
> return Ok(());
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-12 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 9:18 [pbs-devel] [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed Hannes Laimer
2023-09-12 9:30 ` [pbs-devel] applied: " Fabian Grünbichler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox