From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit] fix #4951: accept undefined as value for the MultiDiskSelector
Date: Thu, 7 Sep 2023 14:18:05 +0200 [thread overview]
Message-ID: <20230907121805.1634804-1-d.csapak@proxmox.com> (raw)
otherwise it tries to string split it and throws an exception
This can happen when there was no initial value and the form is reset.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/form/MultiDiskSelector.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/form/MultiDiskSelector.js b/src/form/MultiDiskSelector.js
index 88cdc80..33bcf28 100644
--- a/src/form/MultiDiskSelector.js
+++ b/src/form/MultiDiskSelector.js
@@ -39,6 +39,8 @@ Ext.define('Proxmox.form.MultiDiskSelector', {
setValue: function(value) {
let me = this;
+ value ??= [];
+
if (!Ext.isArray(value)) {
value = value.split(/;, /);
}
--
2.30.2
next reply other threads:[~2023-09-07 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 12:18 Dominik Csapak [this message]
2023-09-07 15:49 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907121805.1634804-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox