public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] close #3777: api: Add source information to backup logs
@ 2023-08-21  7:40 Gabriel Goller
  2023-09-07 16:53 ` Thomas Lamprecht
  0 siblings, 1 reply; 5+ messages in thread
From: Gabriel Goller @ 2023-08-21  7:40 UTC (permalink / raw)
  To: pbs-devel

This will show the ip-address of the client creating
the backup in the logs. For example it will output:
"starting new backup on datastore 'test1' from ::ffff:192.168.1.192:
"host/test/2023-08-21T07:28:10Z"".

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/api2/backup/mod.rs | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs
index 652d5baa..0c996e62 100644
--- a/src/api2/backup/mod.rs
+++ b/src/api2/backup/mod.rs
@@ -214,10 +214,21 @@ fn upgrade_to_backup_protocol(
                 env.debug = debug;
                 env.last_backup = last_backup;
 
-                env.log(format!(
-                    "starting new {} on datastore '{}': {:?}",
-                    worker_type, store, path
-                ));
+                match rpcenv.get_client_ip() {
+                    Some(address) => {
+                        env.log(format!(
+                            "starting new {} on datastore '{}' from {}: {:?}",
+                            worker_type, store, address.ip(), path
+                        ));
+                    },
+                    None => {
+                        env.log(format!(
+                            "starting new {} on datastore '{}': {:?}",
+                            worker_type, store, path
+                        ));
+
+                    }
+                }
 
                 let service =
                     H2Service::new(env.clone(), worker.clone(), &BACKUP_API_ROUTER, debug);
-- 
2.39.2





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-13  8:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21  7:40 [pbs-devel] [PATCH proxmox-backup] close #3777: api: Add source information to backup logs Gabriel Goller
2023-09-07 16:53 ` Thomas Lamprecht
2023-09-08 14:01   ` Gabriel Goller
2023-09-13  7:08     ` Thomas Lamprecht
2023-09-13  8:12       ` Gabriel Goller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal