From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics
Date: Tue, 1 Aug 2023 11:29:54 +0200 [thread overview]
Message-ID: <20230801092954.1686860-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230801092954.1686860-1-d.csapak@proxmox.com>
inspired by how we show volume statistics for tape drives
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we could also add it as a tooltip somewhere else, eg the size column
also, this pattern for the window could be refactored into a
'keyvalueinfowindow' (or something like that), since we already use that
pattern a few time
www/datastore/Content.js | 56 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 9fc07d49..bb2d76ee 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -711,6 +711,56 @@ Ext.define('PBS.DataStoreContent', {
});
},
+ showUploadStatistics: function(view, rI, cI, item, e, rec) {
+ let me = this;
+
+ let list = [];
+
+ let keyMap = {
+ count: gettext('Chunk Count'),
+ duplicates: gettext('Duplicate Chunks'),
+ size: gettext('Size'),
+ compressed_size: gettext('Compressed Size'),
+ };
+
+ for (let [key, val] of Object.entries(rec.data['upload-statistic'])) {
+ if (key === 'size' || key === 'compressed_size') {
+ val = Proxmox.Utils.format_size(val);
+ }
+
+ list.push({ key: keyMap[key] ?? key, value: val });
+ }
+
+ Ext.create('Ext.window.Window', {
+ title: gettext('Upload Statistics'),
+ modal: true,
+ width: 600,
+ height: 250,
+ layout: 'fit',
+ scrollable: true,
+ items: [
+ {
+ xtype: 'grid',
+ store: {
+ data: list,
+ },
+ columns: [
+ {
+ text: gettext('Property'),
+ dataIndex: 'key',
+ flex: 1,
+ },
+ {
+ text: gettext('Value'),
+ dataIndex: 'value',
+ flex: 1,
+ },
+ ],
+ },
+ ],
+ }).show();
+ },
+
onForget: function(table, rI, cI, item, e, { data }) {
let me = this;
let view = this.getView();
@@ -974,6 +1024,12 @@ Ext.define('PBS.DataStoreContent', {
},
isActionDisabled: (v, r, c, i, rec) => rec.data.ty !== 'dir',
},
+ {
+ handler: 'showUploadStatistics',
+ getTip: (v, m, rec) => Ext.String.format(gettext("Show Upload Statistics of '{0}'"), v),
+ getClass: (v, m, rec) => rec.data.ty === 'dir' ? 'fa fa-info-circle' : 'pmx-hidden',
+ isActionDisabled: (v, r, c, i, rec) => rec.data.ty !== 'dir',
+ },
{
handler: 'onForget',
getTip: (v, m, { data }) => {
--
2.30.2
next prev parent reply other threads:[~2023-08-01 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 9:29 [pbs-devel] [RFC PATCH proxmox-backup 0/3] show upload statistics in gui Dominik Csapak
2023-08-01 9:29 ` [pbs-devel] [RFC PATCH proxmox-backup 1/3] api-types: make UploadStatistic an api type Dominik Csapak
2023-11-27 9:52 ` Thomas Lamprecht
2023-11-27 10:01 ` Dominik Csapak
2023-11-27 10:12 ` Thomas Lamprecht
2023-11-27 10:17 ` Dominik Csapak
2023-11-27 12:44 ` Wolfgang Bumiller
2023-11-27 14:57 ` Dominik Csapak
2023-08-01 9:29 ` [pbs-devel] [RFC PATCH proxmox-backup 2/3] api: datastore: add upload_statistic to snapshot listing Dominik Csapak
2023-11-27 9:08 ` Wolfgang Bumiller
2023-08-01 9:29 ` Dominik Csapak [this message]
2023-11-27 9:28 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics Thomas Lamprecht
2023-11-27 10:04 ` Dominik Csapak
2023-11-27 10:27 ` Thomas Lamprecht
2023-11-27 10:33 ` Dominik Csapak
2023-11-27 12:02 ` Thomas Lamprecht
2023-11-27 12:08 ` Dominik Csapak
2023-11-27 10:07 ` Thomas Lamprecht
2023-11-27 10:15 ` Dominik Csapak
2023-11-27 12:06 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801092954.1686860-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox