From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment
Date: Tue, 18 Jul 2023 13:57:07 +0200 [thread overview]
Message-ID: <20230718115707.452582-1-l.wagner@proxmox.com> (raw)
The regular `textfield` does not support the `deleteEmpty`
setting. Thus, if no comment was entered the configuration
would still end up with an empty `comment` key:
ldap: foo
server ....
bind-dn ...
comment
Fixed by switching over to `proxmoxtextfield`, which properly
deletes empty keys.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/window/AuthEditLDAP.js | 2 +-
src/window/AuthEditOpenId.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
index 6aafb98..eb9700a 100644
--- a/src/window/AuthEditLDAP.js
+++ b/src/window/AuthEditLDAP.js
@@ -187,7 +187,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
columnB: [
{
- xtype: 'textfield',
+ xtype: 'proxmoxtextfield',
name: 'comment',
fieldLabel: gettext('Comment'),
cbind: {
diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
index 52a7521..ca84958 100644
--- a/src/window/AuthEditOpenId.js
+++ b/src/window/AuthEditOpenId.js
@@ -112,7 +112,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
columnB: [
{
- xtype: 'textfield',
+ xtype: 'proxmoxtextfield',
name: 'comment',
fieldLabel: gettext('Comment'),
cbind: {
--
2.39.2
next reply other threads:[~2023-07-18 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 11:57 Lukas Wagner [this message]
2023-09-01 6:55 ` Lukas Wagner
2023-09-07 15:53 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718115707.452582-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox