public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 backup 0/5] Clippy fixes
Date: Fri, 16 Jun 2023 10:27:26 +0200	[thread overview]
Message-ID: <20230616082731.45647-1-m.sandoval@proxmox.com> (raw)

Differences from v1:

- Rebased on top of master
- Changed prefix to backup
- Added space in commits between description and signed by
- Changed commit descriptions to include the "Why is it bad" blurb instead of
  the URL, with the exception of the self-explanatory cast to i64

Maximiliano Sandoval (5):
  clippy fixes: the borrowed expression implements the required traits
  clippy fixes: use of ok_or followed by a function call
  clippy fixes: casting to the same type is unnecessary
  clippy fixes: Box::new(_) of default value
  clippy fixes: deref which would be done by auto-deref

 src/acme/plugin.rs             | 2 +-
 src/api2/admin/datastore.rs    | 2 +-
 src/api2/config/acme.rs        | 4 ++--
 src/api2/node/services.rs      | 4 +++-
 src/api2/tape/drive.rs         | 2 +-
 src/api2/tape/restore.rs       | 2 +-
 src/auth.rs                    | 6 +++---
 src/config/mod.rs              | 4 ++--
 src/config/tfa.rs              | 2 +-
 src/server/jobstate.rs         | 2 +-
 src/tape/drive/virtual_tape.rs | 8 ++++----
 src/tape/encryption_keys.rs    | 2 +-
 src/tape/media_catalog.rs      | 2 +-
 src/tape/media_pool.rs         | 4 +---
 src/tools/disks/mod.rs         | 2 +-
 src/tools/disks/zfs.rs         | 2 +-
 16 files changed, 25 insertions(+), 25 deletions(-)

-- 
2.39.2





             reply	other threads:[~2023-06-16  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  8:27 Maximiliano Sandoval [this message]
2023-06-16  8:27 ` [pbs-devel] [PATCH v2 backup 1/5] clippy fixes: the borrowed expression implements the required traits Maximiliano Sandoval
2023-06-16  8:27 ` [pbs-devel] [PATCH v2 backup 2/5] clippy fixes: use of ok_or followed by a function call Maximiliano Sandoval
2023-06-16  8:27 ` [pbs-devel] [PATCH v2 backup 3/5] clippy fixes: casting to the same type is unnecessary Maximiliano Sandoval
2023-06-16  8:27 ` [pbs-devel] [PATCH v2 backup 4/5] clippy fixes: Box::new(_) of default value Maximiliano Sandoval
2023-06-16  8:38   ` Daniele Paoni
2023-06-16  8:27 ` [pbs-devel] [PATCH v2 backup 5/5] clippy fixes: deref which would be done by auto-deref Maximiliano Sandoval
2023-06-23 10:07 ` [pbs-devel] applied-series: [PATCH v2 backup 0/5] Clippy fixes Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616082731.45647-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal