From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: tape: fix restore datastore mapping parameter construction
Date: Tue, 6 Jun 2023 11:20:45 +0200 [thread overview]
Message-ID: <20230606092045.1782511-1-d.csapak@proxmox.com> (raw)
We recently took into account the selected datastore when restoring from
tape, but the snapshot grids value may not only be a single datastore, it can
also be a list of snapshots, datastores or 'all'.
handle these cases and extract the source datastore correctly.
This fixes tape restoration when not a whole datastore is selected.
Reported in the forum:
https://forum.proxmox.com/threads/restore-from-lto-parameter-verification-errors-store.128445
Fixes: df881ed0 ("ui: tape: fix restoring a single datastore")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this patch should also apply cleanly on the stable-2 branch currently
www/tape/window/TapeRestore.js | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index 2ff7c4dd..c1d3493c 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -380,6 +380,19 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
if (values.store.toString() !== "") {
if (vm.get('singleDatastore')) {
let source = controller.lookup('snapshotGrid').getValue();
+ if (source === 'all') {
+ // all values are selected
+ source = values.store;
+ } else if (Ext.isArray(source)) {
+ if (source[0].indexOf(':') !== -1) {
+ // one or multiple snapshots are selected
+ // extract datastore from first
+ source = source[0].split(':')[0];
+ } else {
+ // one whole datstore is selected
+ source = source[0];
+ }
+ }
datastores.push(`${source}=${values.store}`);
} else {
datastores.push(values.store);
--
2.30.2
next reply other threads:[~2023-06-06 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 9:20 Dominik Csapak [this message]
2023-06-06 11:14 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606092045.1782511-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox