* [pbs-devel] [PATCH proxmox-widget-toolkit] auth ui: ldap: fix 'Anonymous Search' being selected if bind-dn is set
@ 2023-03-28 15:10 Lukas Wagner
2023-03-28 15:51 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-03-28 15:10 UTC (permalink / raw)
To: pbs-devel
Only happened on Chrome, weirdly enough.
Fixed by setting a different default value. Side-effect: When creating a
new realm, the checkbox is not selected now.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/window/AuthEditLDAP.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
index 3e8ce88..849be99 100644
--- a/src/window/AuthEditLDAP.js
+++ b/src/window/AuthEditLDAP.js
@@ -6,7 +6,7 @@ Ext.define('Proxmox.panel.LDAPInputPanelViewModel', {
data: {
mode: 'ldap',
- anonymous_search: 1,
+ anonymous_search: 0,
},
formulas: {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [pbs-devel] [PATCH proxmox-widget-toolkit] auth ui: ldap: fix 'Anonymous Search' being selected if bind-dn is set
2023-03-28 15:10 [pbs-devel] [PATCH proxmox-widget-toolkit] auth ui: ldap: fix 'Anonymous Search' being selected if bind-dn is set Lukas Wagner
@ 2023-03-28 15:51 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-03-28 15:51 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Lukas Wagner
Am 28/03/2023 um 17:10 schrieb Lukas Wagner:
> Only happened on Chrome, weirdly enough.
>
> Fixed by setting a different default value. Side-effect: When creating a
> new realm, the checkbox is not selected now.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/window/AuthEditLDAP.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
> index 3e8ce88..849be99 100644
> --- a/src/window/AuthEditLDAP.js
> +++ b/src/window/AuthEditLDAP.js
> @@ -6,7 +6,7 @@ Ext.define('Proxmox.panel.LDAPInputPanelViewModel', {
>
> data: {
> mode: 'ldap',
> - anonymous_search: 1,
> + anonymous_search: 0,
> },
>
> formulas: {
As written off-list, so just for reference:
Replaced this by keeping the default but setting the view model data explicitly
in onSetValues (i.e., on edit):
https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=4d3a18dfc3a37520f0eb82fec120fcc0da625583
While that may not be the best fix, it's a bit less brittle & subtle, and avoids
the need to change user facing behavior for a framerwork/browser limitation/bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-28 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-28 15:10 [pbs-devel] [PATCH proxmox-widget-toolkit] auth ui: ldap: fix 'Anonymous Search' being selected if bind-dn is set Lukas Wagner
2023-03-28 15:51 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox