From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [RFC proxmox-backup] drop exclusive lock for verify-after-complete
Date: Mon, 27 Mar 2023 15:09:12 +0200 [thread overview]
Message-ID: <20230327130912.sok4n5x7quoxcj2p@casey.proxmox.com> (raw)
In-Reply-To: <20230227095012.291373-1-f.gruenbichler@proxmox.com>
applied
On Mon, Feb 27, 2023 at 10:50:12AM +0100, Fabian Grünbichler wrote:
> the backup is finished at that point, the only lock clash that is possible when
> dropping the exclusive and attempting to obtain a shared lock would be
>
> - the snapshot is pruned/removed
> - the backup is in a pre-upgrade process, and the post-upgrade process opens a reader
>
> the first case is OK, if the other invocation wins the race and removes the
> snapshot verification is pointless anyway.
>
> the second case means the snapshot is not verified directly after completion
> (this fact would be logged in the backup task log), but usable immediately for
> pulling/restoring/..
>
> this should decrease the chances of triggering the issues described in #4523
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> right now our locking helpers don't support a direct downgrade (or attempt to
> upgrade, for that matter). given that we don't have many use cases that require
up/downgrading existing locks is a weird thing to do anyway and either
ruins the queues (or fails) anyway...
prev parent reply other threads:[~2023-03-27 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:50 [pbs-devel] " Fabian Grünbichler
2023-03-27 13:09 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327130912.sok4n5x7quoxcj2p@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox