* [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message
@ 2023-03-07 14:10 Dominik Csapak
2023-03-07 14:50 ` [pbs-devel] applied: " Wolfgang Bumiller
2023-03-07 18:36 ` [pbs-devel] " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2023-03-07 14:10 UTC (permalink / raw)
To: pbs-devel
we try to create the job stat dir, not the rrdb one
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/server/jobstate.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs
index 4f347ad1..74af992f 100644
--- a/src/server/jobstate.rs
+++ b/src/server/jobstate.rs
@@ -88,7 +88,7 @@ pub fn create_jobstate_dir() -> Result<(), Error> {
.group(backup_user.gid);
create_path(JOB_STATE_BASEDIR, Some(opts.clone()), Some(opts))
- .map_err(|err: Error| format_err!("unable to create rrdb stat dir - {}", err))?;
+ .map_err(|err: Error| format_err!("unable to create job stat dir - {}", err))?;
Ok(())
}
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] jobstate: fix wrong error message
2023-03-07 14:10 [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message Dominik Csapak
@ 2023-03-07 14:50 ` Wolfgang Bumiller
2023-03-07 18:36 ` [pbs-devel] " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Bumiller @ 2023-03-07 14:50 UTC (permalink / raw)
To: Dominik Csapak; +Cc: pbs-devel
On Tue, Mar 07, 2023 at 03:10:57PM +0100, Dominik Csapak wrote:
> we try to create the job stat dir, not the rrdb one
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/server/jobstate.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs
> index 4f347ad1..74af992f 100644
> --- a/src/server/jobstate.rs
> +++ b/src/server/jobstate.rs
> @@ -88,7 +88,7 @@ pub fn create_jobstate_dir() -> Result<(), Error> {
> .group(backup_user.gid);
>
> create_path(JOB_STATE_BASEDIR, Some(opts.clone()), Some(opts))
> - .map_err(|err: Error| format_err!("unable to create rrdb stat dir - {}", err))?;
> + .map_err(|err: Error| format_err!("unable to create job stat dir - {}", err))?;
applied & changed stat -> state...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message
2023-03-07 14:10 [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message Dominik Csapak
2023-03-07 14:50 ` [pbs-devel] applied: " Wolfgang Bumiller
@ 2023-03-07 18:36 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-03-07 18:36 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
Am 07/03/2023 um 15:10 schrieb Dominik Csapak:
> we try to create the job stat dir, not the rrdb one
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/server/jobstate.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs
> index 4f347ad1..74af992f 100644
> --- a/src/server/jobstate.rs
> +++ b/src/server/jobstate.rs
> @@ -88,7 +88,7 @@ pub fn create_jobstate_dir() -> Result<(), Error> {
> .group(backup_user.gid);
>
> create_path(JOB_STATE_BASEDIR, Some(opts.clone()), Some(opts))
> - .map_err(|err: Error| format_err!("unable to create rrdb stat dir - {}", err))?;
> + .map_err(|err: Error| format_err!("unable to create job stat dir - {}", err))?;
no biggie, but in general feel free (or even encouraged) to inline format string
variables when touching lines anyway, like {err} here.
>
> Ok(())
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-07 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 14:10 [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message Dominik Csapak
2023-03-07 14:50 ` [pbs-devel] applied: " Wolfgang Bumiller
2023-03-07 18:36 ` [pbs-devel] " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox