Re: [pbs-devel] [PATCH v3 proxmox-backup 10/18] manager: add commands for managing LDAP realms

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Fri, Feb 10, 2023 at 11:30:48AM +0100, Lukas Wagner wrote:
> Thanks for the feedback, Fabian!
> 
> On 2/10/23 11:16, Fabian Grünbichler wrote:
> > > +            proxmox_rest_server::handle_worker(upid).await?;
> > > +        }
> > > +    }
> > 
> > possibly late to the party given that the "handle_worker" move got applied already..
> > 
> > is there a good reason for introducing this instead of calling the endpoint over
> > the API and using the "I just spawned a task and want to poll the output" helper
> > (pbs_client::view_task_result), like the rest of proxmox-backup-manager does?
> > 
> 
> Good point. I missed that the functionality was already present ;).
> I used the debug-cli client as guidance, since that was what I was using for early
> testing.
> 
> It would probably make sense to change it then?

Can be changed as a follow-up.
Together with the line-length fixups for the docs part.

(The rest-server crate will get some more bumps soon anyway, so I can
remove it again if we stop using it.)