Re: [pbs-devel] [RFC PATCH v2 proxmox-backup 1/7] api2: Introduce server features discovery mechanism

[Christoph Heiss <c.heiss@proxmox.com>]

Thanks for taking a look a this!

On Wed, Jan 25, 2023 at 04:56:26PM +0100, Thomas Lamprecht wrote:
> Am 25/01/2023 um 13:18 schrieb Christoph Heiss:
> > [..]
>
> you could also just check the version? that's already there, no need for
> adding extra complexity.
>
> tbh, I'd be fine without any such check, as new *client* needing newer
> server is fine; one just does need to ensure that old clients still work
> with new server.
I thought about that too at first - seemed a bit "hacky" too me, but if
it is also fine by you, I will happily drop this patch and just check the
server version.

Will do a v3 soon with that incorporated, barring other feedback on that
matter. I'm very happy about better proposals for any of this stuff,
since this grew considerably from what I initally thought should be a
relatively simple fix.

>
> If you want, you could catch the parameter exception in the PVE call
> site, either adding a hint about "new server required" or falling back
> there (albeit I'm not so liking that).
>
> After all immediate protection of backups is only relevant for manual
> trigerring that, not for the scheduled backup jobs, so it won't affect
> existing PVE jobs anyway.