public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox-backup/widget-toolkit] Handle optional services and expose more details
Date: Thu, 22 Dec 2022 13:05:48 +0100	[thread overview]
Message-ID: <20221222120549.3958127-1-c.heiss@proxmox.com> (raw)

Add the `unit-state` property for services to the PBS api, much like
it's PVE counterpart. This avoids erroneously marking services as dead
that might be just not installed, e.g. systemd-timesyncd.

On the GUI side, this functionality already exists (from PVE), just the
appropriate cookie name needs to be added.

See also #4406.

---
Changes since v1:
* Fall back to `SubState` if `Result` is not present

---
proxmox-backup:

Christoph Heiss (1):
      api2/node/services: Handle optional services and expose unit-state

 src/api2/node/services.rs | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

 proxmox-widget-toolkit:

 Christoph Heiss (1):
      node/ServiceView: Show unit-state column in PBS too

 src/node/ServiceView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)






             reply	other threads:[~2022-12-22 12:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 12:05 Christoph Heiss [this message]
2022-12-22 12:05 ` [pbs-devel] [PATCH v2 proxmox-backup] api2/node/services: Handle optional services and expose unit-state Christoph Heiss
2023-01-05  9:38   ` Thomas Lamprecht
2022-12-22 12:05 ` [pbs-devel] [PATCH v2 widget-toolkit] node/ServiceView: Show unit-state column in PBS too Christoph Heiss
2023-01-05  9:25 ` [pbs-devel] applied: [PATCH v2 proxmox-backup/widget-toolkit] Handle optional services and expose more details Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221222120549.3958127-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal