[pbs-devel] [PATCH proxmox-backup] fix #4387: pbs-client: print task-logs to stdout

[pbs-devel] [PATCH proxmox-backup] fix #4387: pbs-client: print task-logs to stdout

[Hannes Laimer]

... since those logs are the result of the command.
---
 pbs-client/src/task_log.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pbs-client/src/task_log.rs b/pbs-client/src/task_log.rs
index a396a451..960653de 100644
--- a/pbs-client/src/task_log.rs
+++ b/pbs-client/src/task_log.rs
@@ -77,9 +77,9 @@ pub async fn display_task_log(
                 }
                 if strip_date && t.len() > 27 && &t[25..27] == ": " {
                     let line = &t[27..];
-                    log::info!("{}", line);
+                    println!("{}", line);
                 } else {
-                    log::info!("{}", t);
+                    println!("{}", t);
                 }
                 start += 1;
             }
-- 
2.30.2

Re: [pbs-devel] [PATCH proxmox-backup] fix #4387: pbs-client: print task-logs to stdout

[Wolfgang Bumiller]

Applied this as a quick fix, but I'd actually like to avoid having
output like that in library crates.
This just ended up here as it is shared between pbs and the
client-binary, but a better API when sharing this would be to take a
`mut output: impl Write` and use the `write!()` macro on that.

On Mon, Dec 19, 2022 at 12:20:24PM +0100, Hannes Laimer wrote:
> ... since those logs are the result of the command.
> ---
>  pbs-client/src/task_log.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pbs-client/src/task_log.rs b/pbs-client/src/task_log.rs
> index a396a451..960653de 100644
> --- a/pbs-client/src/task_log.rs
> +++ b/pbs-client/src/task_log.rs
> @@ -77,9 +77,9 @@ pub async fn display_task_log(
>                  }
>                  if strip_date && t.len() > 27 && &t[25..27] == ": " {
>                      let line = &t[27..];
> -                    log::info!("{}", line);
> +                    println!("{}", line);
>                  } else {
> -                    log::info!("{}", t);
> +                    println!("{}", t);
>                  }
>                  start += 1;
>              }
> -- 
> 2.30.2