From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4387: pbs-client: print task-logs to stdout
Date: Tue, 20 Dec 2022 09:29:54 +0100 [thread overview]
Message-ID: <20221220082954.yurgsdu33btfujnj@casey.proxmox.com> (raw)
In-Reply-To: <20221219112024.154864-1-h.laimer@proxmox.com>
Applied this as a quick fix, but I'd actually like to avoid having
output like that in library crates.
This just ended up here as it is shared between pbs and the
client-binary, but a better API when sharing this would be to take a
`mut output: impl Write` and use the `write!()` macro on that.
On Mon, Dec 19, 2022 at 12:20:24PM +0100, Hannes Laimer wrote:
> ... since those logs are the result of the command.
> ---
> pbs-client/src/task_log.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-client/src/task_log.rs b/pbs-client/src/task_log.rs
> index a396a451..960653de 100644
> --- a/pbs-client/src/task_log.rs
> +++ b/pbs-client/src/task_log.rs
> @@ -77,9 +77,9 @@ pub async fn display_task_log(
> }
> if strip_date && t.len() > 27 && &t[25..27] == ": " {
> let line = &t[27..];
> - log::info!("{}", line);
> + println!("{}", line);
> } else {
> - log::info!("{}", t);
> + println!("{}", t);
> }
> start += 1;
> }
> --
> 2.30.2
prev parent reply other threads:[~2022-12-20 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 11:20 Hannes Laimer
2022-12-20 8:29 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220082954.yurgsdu33btfujnj@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox