From: Stefan Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] email_notifications: make html template more valid
Date: Tue, 29 Nov 2022 17:40:19 +0100 [thread overview]
Message-ID: <20221129164019.1193392-1-s.sterz@proxmox.com> (raw)
some webmail interfaces may behave unexpectedly if the html is
invalid. thus, close tags and declare a language.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
src/server/email_notifications.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/server/email_notifications.rs b/src/server/email_notifications.rs
index b3298cf9..378e805e 100644
--- a/src/server/email_notifications.rs
+++ b/src/server/email_notifications.rs
@@ -294,7 +294,7 @@ fn send_job_status_mail(email: &str, subject: &str, text: &str) -> Result<(), Er
// Note: OX has serious problems displaying text mails,
// so we include html as well
let html = format!(
- "<html><body><pre>\n{}\n<pre>",
+ "<html lang=\"en\"><head></head><body><pre>\n{}\n</pre></body></html>",
handlebars::html_escape(text)
);
--
2.30.2
next reply other threads:[~2022-11-29 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 16:40 Stefan Sterz [this message]
2022-11-30 14:26 ` Dominik Csapak
2022-11-30 15:02 ` Stefan Sterz
2022-11-30 15:14 ` Dominik Csapak
2022-11-30 15:19 ` Stefan Sterz
2022-11-30 16:09 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129164019.1193392-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox