From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup] disk: smartctl: ignore bit 2 of exitcode
Date: Thu, 24 Nov 2022 14:47:57 +0100 [thread overview]
Message-ID: <20221124134757.fmjpcsvzpw4io3ey@casey.proxmox.com> (raw)
In-Reply-To: <20221124101709.2712920-1-d.csapak@proxmox.com>
applied, thanks
On Thu, Nov 24, 2022 at 11:17:09AM +0100, Dominik Csapak wrote:
> under some conditions, the smartctl exitcode sets bit 2, even if the
> smartctl call succeeded, but has e.g. some warnings derived from the
> attributes
>
> we do the same in pve, but it is only the first step in fixing #4353, since
> we probably should parse the smartcl output better to include
> such warnings
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/tools/disks/smart.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/tools/disks/smart.rs b/src/tools/disks/smart.rs
> index 180ddfe9..a99404dc 100644
> --- a/src/tools/disks/smart.rs
> +++ b/src/tools/disks/smart.rs
> @@ -94,7 +94,7 @@ pub fn get_smart_data(disk: &super::Disk, health_only: bool) -> Result<SmartData
> let output = proxmox_sys::command::run_command(
> command,
> Some(
> - |exitcode| (exitcode & 0b0111) == 0, // only bits 0-2 are fatal errors
> + |exitcode| (exitcode & 0b0011) == 0, // only bits 0-1 are fatal errors
> ),
> )?;
>
> --
> 2.30.2
prev parent reply other threads:[~2022-11-24 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 10:17 [pbs-devel] " Dominik Csapak
2022-11-24 13:47 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124134757.fmjpcsvzpw4io3ey@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox