From: w.bumiller@proxmox.com
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/1] fix #3828: proxmox_backup_debug: Introduce `diff archive` subcommand.
Date: Wed, 23 Nov 2022 11:26:18 +0100 [thread overview]
Message-ID: <20221123102618.krsjmm6dfwdvxgkt@casey.proxmox.com> (raw)
In-Reply-To: <20221028100143.9035-2-l.wagner@proxmox.com>
Applied and fixe dup the `c/b` entries to show the actual device type.
But I would like to see some improvements still.
The output is *very* terse and lacks some information that I find is
sort of important (ie. *what* changed - size, mtime, type...).
Particularly the file type is interesting, since currently if that changes
it'll simply display the *old* type in the output.
Eg.
M f root/asdf
where I modified `/root/asdf` from a regular file to a chardev.
I'd expect at least the new type ;-)
maybe even something like
M f>c root/asdf
(if we add this, the 2 extra spaces should be added where no change
happened for alignment)
Or simply '*' for a change if we want to stick to short "it just
changed" info...
I also think an opt-in to compare the actual contents would make sense.
Eg. currently files such as `/etc/hostname` will always show up if the
container had been restarted between backups since we re-write it on
container start even if it hasn't been changed, so the mtime will be
different.
next prev parent reply other threads:[~2022-11-23 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:01 [pbs-devel] [PATCH v2 proxmox-backup 0/1] " Lukas Wagner
2022-10-28 10:01 ` [pbs-devel] [PATCH v2 proxmox-backup 1/1] " Lukas Wagner
2022-11-23 10:26 ` w.bumiller [this message]
2022-11-23 15:46 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123102618.krsjmm6dfwdvxgkt@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox