public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: prune job edit: fix disabling jobs
Date: Mon, 14 Nov 2022 10:42:58 +0100	[thread overview]
Message-ID: <20221114094258.35795-1-f.ebner@proxmox.com> (raw)

The backend doesn't have an 'enable' option, but 'disable'. Could be
converted before sending and after loading, but it's cleaner to just
align it with the backend.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/window/PruneJobEdit.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
index 87be71ad..1b43b31f 100644
--- a/www/window/PruneJobEdit.js
+++ b/www/window/PruneJobEdit.js
@@ -112,11 +112,11 @@ Ext.define('PBS.window.PruneJobEdit', {
 	    },
 	    {
 		xtype: 'proxmoxcheckbox',
-		fieldLabel: gettext('Enabled'),
-		name: 'enable',
-		uncheckedValue: 0,
-		defaultValue: 1,
-		checked: true,
+		fieldLabel: gettext('Disabled'),
+		name: 'disable',
+		uncheckedValue: false,
+		defaultValue: true,
+		checked: false,
 	    },
 	],
 
-- 
2.30.2





             reply	other threads:[~2022-11-14  9:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  9:42 Fiona Ebner [this message]
2022-11-14 10:54 ` Dominik Csapak
2022-11-14 13:26   ` Fabian Grünbichler
2022-11-14 14:01     ` Dominik Csapak
2022-11-15 14:29 ` Thomas Lamprecht
2022-11-16  9:41   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221114094258.35795-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal