From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] file-restore: fix deprecated qemu parameters
Date: Mon, 31 Oct 2022 12:39:52 +0100 [thread overview]
Message-ID: <20221031113953.3111599-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20221031113953.3111599-1-d.csapak@proxmox.com>
server and nowait are deprecated, so we should use the longform:
server=on and wait=off
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
proxmox-file-restore/src/qemu_helper.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-file-restore/src/qemu_helper.rs b/proxmox-file-restore/src/qemu_helper.rs
index fffa3bd9..d6f4c5a9 100644
--- a/proxmox-file-restore/src/qemu_helper.rs
+++ b/proxmox-file-restore/src/qemu_helper.rs
@@ -264,7 +264,7 @@ pub async fn start_vm(
let debug_args = [
"-chardev",
&format!(
- "socket,id=debugser,path=/run/proxmox-backup/file-restore-serial-{}.sock,server,nowait",
+ "socket,id=debugser,path=/run/proxmox-backup/file-restore-serial-{}.sock,server=on,wait=off",
cid
),
"-serial",
--
2.30.2
next prev parent reply other threads:[~2022-10-31 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:39 [pbs-devel] [RFC PATCH backup-restore-image/proxmox-backup] improve file-restore for zpools Dominik Csapak
2022-10-31 11:39 ` [pbs-devel] [RFC PATCH backup-restore-image 1/1] add kernel config options for memory hotplug Dominik Csapak
2022-11-07 12:48 ` [pbs-devel] applied: " Wolfgang Bumiller
2022-10-31 11:39 ` Dominik Csapak [this message]
2022-11-04 12:29 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] file-restore: fix deprecated qemu parameters Wolfgang Bumiller
2022-10-31 11:39 ` [pbs-devel] [RFC PATCH proxmox-backup 2/2] file-restore: dynamically increase memory of vm for zpools Dominik Csapak
2022-11-07 12:35 ` [pbs-devel] applied: " Wolfgang Bumiller
2022-11-07 17:15 ` Thomas Lamprecht
2022-11-08 7:59 ` Dominik Csapak
2022-11-08 9:19 ` Thomas Lamprecht
2022-11-08 10:07 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031113953.3111599-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox